Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1686277 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-07-13 08:20 +0200 |
| Last post | 2017-07-13 08:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: spear: spdif_in: constify snd_soc_dai_ops structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 08:20 +0200
Re: [PATCH] ASoC: spear: spdif_in: constify snd_soc_dai_ops structure Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-13 08:30 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-13 08:20 +0200 |
| Subject | [PATCH] ASoC: spear: spdif_in: constify snd_soc_dai_ops structure |
| Message-ID | <u2FDI-1Wm-25@gated-at.bofh.it> |
This structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/soc/spear/spdif_in.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c
index 7f32527..d9368e1 100644
--- a/sound/soc/spear/spdif_in.c
+++ b/sound/soc/spear/spdif_in.c
@@ -151,7 +151,7 @@ static int spdif_in_trigger(struct snd_pcm_substream *substream, int cmd,
return ret;
}
-static struct snd_soc_dai_ops spdif_in_dai_ops = {
+static const struct snd_soc_dai_ops spdif_in_dai_ops = {
.shutdown = spdif_in_shutdown,
.trigger = spdif_in_trigger,
.hw_params = spdif_in_hw_params,
--
2.5.0
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-07-13 08:30 +0200 |
| Message-ID | <u2FNo-1ZF-11@gated-at.bofh.it> |
| In reply to | #1686277 |
On Thu, Jul 13, 2017 at 11:27 AM, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote: > This structure is only stored in the ops field of a snd_soc_dai_driver > structure. That field is declared const, so snd_soc_dai_ops structures > that have this property can be declared as const also. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > sound/soc/spear/spdif_in.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web