Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1685498 > unrolled thread
| Started by | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| First post | 2017-07-12 06:00 +0200 |
| Last post | 2017-07-13 08:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-12 06:00 +0200
Re: [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table Stephen Boyd <sboyd@codeaurora.org> - 2017-07-13 08:20 +0200
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-07-12 06:00 +0200 |
| Subject | [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table |
| Message-ID | <u2gYF-2Rz-1@gated-at.bofh.it> |
Some platforms add the OPPs dynamically from platform specific drivers
instead of getting them statically from DT. The cpufreq-dt driver
already ignores the return value of dev_pm_opp_of_cpumask_add_table() to
not error out for such cases, but we still end up printing error message
from that routine. That's not nice.
Convert the print message to use pr_debug() instead.
Reported-by: Mason <slash.tmp@free.fr>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp/of.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c
index 779428676f63..f1d8b01db546 100644
--- a/drivers/base/power/opp/of.c
+++ b/drivers/base/power/opp/of.c
@@ -533,8 +533,12 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask)
ret = dev_pm_opp_of_add_table(cpu_dev);
if (ret) {
- pr_err("%s: couldn't find opp table for cpu:%d, %d\n",
- __func__, cpu, ret);
+ /*
+ * OPP may get registered dynamically, don't print error
+ * message here.
+ */
+ pr_debug("%s: couldn't find opp table for cpu:%d, %d\n",
+ __func__, cpu, ret);
/* Free all other OPPs */
dev_pm_opp_of_cpumask_remove_table(cpumask);
--
2.13.0.71.gd7076ec9c9cb
[toc] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-07-13 08:20 +0200 |
| Subject | Re: [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table |
| Message-ID | <u2FDH-1Wm-7@gated-at.bofh.it> |
| In reply to | #1685498 |
On 07/12, Viresh Kumar wrote: > Some platforms add the OPPs dynamically from platform specific drivers > instead of getting them statically from DT. The cpufreq-dt driver > already ignores the return value of dev_pm_opp_of_cpumask_add_table() to > not error out for such cases, but we still end up printing error message > from that routine. That's not nice. > > Convert the print message to use pr_debug() instead. > > Reported-by: Mason <slash.tmp@free.fr> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web