Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1685319 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-11 21:50 +0200 |
| Last post | 2017-07-18 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call Colin King <colin.king@canonical.com> - 2017-07-11 21:50 +0200
Re: [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call Juergen Gross <jgross@suse.com> - 2017-07-18 10:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-11 21:50 +0200 |
| Subject | [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call |
| Message-ID | <u29ku-6uK-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Currently a sock_release on map->sock will result in a null pointer
deference on map when map is null. Instead, the sock_relase sould
be on sock and not map->sock.
Detected by CoverityScan, CID#1450169 ("Dereference after null check")
Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/pvcalls-back.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index d6c4c4aecb41..01b690e1e555 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -424,7 +424,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev,
sock);
if (!map) {
ret = -EFAULT;
- sock_release(map->sock);
+ sock_release(sock);
}
out:
--
2.11.0
[toc] | [next] | [standalone]
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2017-07-18 10:10 +0200 |
| Subject | Re: [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call |
| Message-ID | <u4vJU-8k9-23@gated-at.bofh.it> |
| In reply to | #1685319 |
On 11/07/17 21:41, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a sock_release on map->sock will result in a null pointer
> deference on map when map is null. Instead, the sock_relase sould
> be on sock and not map->sock.
>
> Detected by CoverityScan, CID#1450169 ("Dereference after null check")
>
> Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Committed to xen/tip for-linus-4.13
Thanks,
Juergen
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web