Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1684986 > unrolled thread

[PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1

Started byHans de Goede <hdegoede@redhat.com>
First post2017-07-11 13:50 +0200
Last post2017-07-11 18:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1 Hans de Goede <hdegoede@redhat.com> - 2017-07-11 13:50 +0200
    Re: [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter  handling off by 1 Darren Hart <dvhart@infradead.org> - 2017-07-11 18:20 +0200

#1684986 — [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1

FromHans de Goede <hdegoede@redhat.com>
Date2017-07-11 13:50 +0200
Subject[PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1
Message-ID<u21PX-1KO-1@gated-at.bofh.it>
If peaq_ignore_events_counter gets set to 1 we should skip polling 1
time, rather then ignoring it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/peaq-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c
index 23942d5b3525..6e6a3e650e1b 100644
--- a/drivers/platform/x86/peaq-wmi.c
+++ b/drivers/platform/x86/peaq-wmi.c
@@ -50,7 +50,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev)
 		return;
 	}
 
-	if (peaq_ignore_events_counter && --peaq_ignore_events_counter > 0)
+	if (peaq_ignore_events_counter && --peaq_ignore_events_counter >= 0)
 		return;
 
 	if (obj.integer.value) {
-- 
2.13.0

[toc] | [next] | [standalone]


#1685189 — Re: [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1

FromDarren Hart <dvhart@infradead.org>
Date2017-07-11 18:20 +0200
SubjectRe: [PATCH] platform/x86: peaq-wmi: Fix peaq_ignore_events_counter handling off by 1
Message-ID<u263h-4Bc-35@gated-at.bofh.it>
In reply to#1684986
On Tue, Jul 11, 2017 at 01:41:34PM +0200, Hans de Goede wrote:
> If peaq_ignore_events_counter gets set to 1 we should skip polling 1
> time, rather then ignoring it.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Thanks Hans, queued to testing.

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web