Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684922 > unrolled thread

[PATCH 0/3] constify pci attribute_group structures.

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] constify pci attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 11:30 +0200
    [PATCH 2/3] PCI: pci-label: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 11:30 +0200
    Re: [PATCH 0/3] constify pci attribute_group structures. Bjorn Helgaas <helgaas@kernel.org> - 2017-07-13 05:30 +0200

#1684922 — [PATCH 0/3] constify pci attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] PCI: pci-sysfs: constify attribute_group structures.
  [PATCH 2/3] PCI: pci-label: constify attribute_group structures.
  [PATCH 3/3] PCI: hotplug: constify attribute_group structures.

 drivers/pci/hotplug/rpadlpar_sysfs.c |  2 +-
 drivers/pci/pci-label.c              |  4 ++--
 drivers/pci/pci-sysfs.c              | 10 +++++-----
 3 files changed, 8 insertions(+), 8 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1684923 — [PATCH 2/3] PCI: pci-label: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
    930	    320	      0	   1250	    4e2	drivers/pci/pci-label.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   1058	    192	      0	   1250	    4ca	drivers/pci/pci-label.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/pci/pci-label.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci-label.c b/drivers/pci/pci-label.c
index a7a41d9..7e9e795 100644
--- a/drivers/pci/pci-label.c
+++ b/drivers/pci/pci-label.c
@@ -123,7 +123,7 @@ static ssize_t smbiosinstance_show(struct device *dev,
 	NULL,
 };
 
-static struct attribute_group smbios_attr_group = {
+static const struct attribute_group smbios_attr_group = {
 	.attrs = smbios_attributes,
 	.is_visible = smbios_instance_string_exist,
 };
@@ -260,7 +260,7 @@ static ssize_t acpiindex_show(struct device *dev,
 	NULL,
 };
 
-static struct attribute_group acpi_attr_group = {
+static const struct attribute_group acpi_attr_group = {
 	.attrs = acpi_attributes,
 	.is_visible = acpi_index_string_exist,
 };
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1686213

On Tue, Jul 11, 2017 at 02:57:06PM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> Arvind Yadav (3):
>   [PATCH 1/3] PCI: pci-sysfs: constify attribute_group structures.
>   [PATCH 2/3] PCI: pci-label: constify attribute_group structures.
>   [PATCH 3/3] PCI: hotplug: constify attribute_group structures.
> 
>  drivers/pci/hotplug/rpadlpar_sysfs.c |  2 +-
>  drivers/pci/pci-label.c              |  4 ++--
>  drivers/pci/pci-sysfs.c              | 10 +++++-----
>  3 files changed, 8 insertions(+), 8 deletions(-)

Applied to pci/misc for v4.14, thanks!

For some reason the list got two copies of the cover letter and patch
3 was a response to the *second* cover letter.  But I think I got the
right stuff.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web