Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684835 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-07-11 09:40 +0200 |
| Last post | 2017-07-11 09:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 00/10] Constify attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 09:40 +0200
[PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 09:40 +0200
[PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 09:40 +0200
Re: [PATCH v2 00/10] Constify attribute_group structures Marc Kleine-Budde <mkl@pengutronix.de> - 2017-07-11 09:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-11 09:40 +0200 |
| Subject | [PATCH v2 00/10] Constify attribute_group structures |
| Message-ID | <u1XW1-7MF-5@gated-at.bofh.it> |
attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures. [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures. [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures. [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures. [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures. [PATCH v2 09/10] net: bonding: constify attribute_group structures. [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures. drivers/net/arcnet/com20020-pci.c | 2 +- drivers/net/bonding/bond_sysfs.c | 2 +- drivers/net/can/at91_can.c | 2 +- drivers/net/can/janz-ican3.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++-- drivers/net/usb/cdc_ncm.c | 2 +- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- 10 files changed, 15 insertions(+), 11 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-11 09:40 +0200 |
| Subject | [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. |
| Message-ID | <u1XW2-7MF-25@gated-at.bofh.it> |
| In reply to | #1684835 |
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/netdevice.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6164 304 0 6468 1944 drivers/net/can/at91_can.o
File size After adding 'const':
text data bss dec hex filename
6228 240 0 6468 1944 drivers/net/can/at91_can.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
drivers/net/can/at91_can.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index 0e0df0b..f37ce0e 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -1232,7 +1232,7 @@ static DEVICE_ATTR(mb0_id, S_IWUSR | S_IRUGO,
NULL,
};
-static struct attribute_group at91_sysfs_attr_group = {
+static const struct attribute_group at91_sysfs_attr_group = {
.attrs = at91_sysfs_attrs,
};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-11 09:40 +0200 |
| Subject | [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures. |
| Message-ID | <u1XW2-7MF-37@gated-at.bofh.it> |
| In reply to | #1684835 |
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/netdevice.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11800 368 0 12168 2f88 drivers/net/can/janz-ican3.o
File size After adding 'const':
text data bss dec hex filename
11864 304 0 12168 2f88 drivers/net/can/janz-ican3.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Added cover later.
drivers/net/can/janz-ican3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index 2ba1a81..12a53c8 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1875,7 +1875,7 @@ static DEVICE_ATTR(termination, S_IWUSR | S_IRUGO, ican3_sysfs_show_term,
NULL,
};
-static struct attribute_group ican3_sysfs_attr_group = {
+static const struct attribute_group ican3_sysfs_attr_group = {
.attrs = ican3_sysfs_attrs,
};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Marc Kleine-Budde <mkl@pengutronix.de> |
|---|---|
| Date | 2017-07-11 09:50 +0200 |
| Message-ID | <u1Y5I-7Q0-11@gated-at.bofh.it> |
| In reply to | #1684835 |
[Multipart message — attachments visible in raw view] — view raw
On 07/11/2017 09:29 AM, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. So mark the > non-const structs as const. [...] > drivers/net/can/at91_can.c | 2 +- > drivers/net/can/janz-ican3.c | 2 +- For the can drivers: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web