Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684830 > unrolled thread

[PATCH v2 00/10] Constify attribute_group structures

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 00/10] Constify attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 09:30 +0200
    [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 09:30 +0200
    Re: [PATCH v2 00/10] Constify attribute_group structures David Miller <davem@davemloft.net> - 2017-07-11 19:40 +0200

#1684830 — [PATCH v2 00/10] Constify attribute_group structures

attribute_groups are not supposed to change at runtime. So mark the
non-const structs as const.

Arvind Yadav (10):
  [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
  [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
  [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
  [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
  [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
  [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
  [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
  [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
  [PATCH v2 09/10] net: bonding: constify attribute_group structures.
  [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.

 drivers/net/arcnet/com20020-pci.c               | 2 +-
 drivers/net/bonding/bond_sysfs.c                | 2 +-
 drivers/net/can/at91_can.c                      | 2 +-
 drivers/net/can/janz-ican3.c                    | 2 +-
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++--
 drivers/net/usb/cdc_ncm.c                       | 2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2100.c    | 2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2200.c    | 2 +-
 drivers/net/wireless/intel/iwlegacy/3945-mac.c  | 2 +-
 drivers/net/wireless/intel/iwlegacy/4965-mac.c  | 2 +-
 10 files changed, 15 insertions(+), 11 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1684831 — [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/netdevice.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  13275	    928	      1	  14204	   377c	drivers/net/usb/cdc_ncm.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  13339	    864	      1	  14204	   377c	drivers/net/usb/cdc_ncm.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
              Added cover later.

 drivers/net/usb/cdc_ncm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index d103a1d..b401ba9 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -367,7 +367,7 @@ static DEVICE_ATTR(name, S_IRUGO, cdc_ncm_show_##name, NULL)
 	NULL,
 };
 
-static struct attribute_group cdc_ncm_sysfs_attr_group = {
+static const struct attribute_group cdc_ncm_sysfs_attr_group = {
 	.name = "cdc_ncm",
 	.attrs = cdc_ncm_sysfs_attrs,
 };
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1685246

From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Tue, 11 Jul 2017 12:52:41 +0530

> attribute_groups are not supposed to change at runtime. So mark the
> non-const structs as const.

Please resubmit this when net-next is open again:

	http://vger.kernel.org/~davem/net-next.html

Thank you.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web