Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684367 > unrolled thread

[PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-07-10 17:50 +0200
    Re: [PATCH v8 1/5] [media] cec.h: Add stub function for  cec_register_cec_notifier() Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-13 09:10 +0200

#1684367 — [PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

Add a new stub function for cec_register_cec_notifier() so that
we can still call this function when CONFIG_CEC_NOTIFIER and
CONFIG_CEC_CORE are not set.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
---
 include/media/cec.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/media/cec.h b/include/media/cec.h
index 56643b2..8357f60 100644
--- a/include/media/cec.h
+++ b/include/media/cec.h
@@ -365,6 +365,14 @@ static inline int cec_phys_addr_validate(u16 phys_addr, u16 *parent, u16 *port)
 	return 0;
 }
 
+#ifndef CONFIG_CEC_NOTIFIER
+struct cec_notifier;
+static inline void cec_register_cec_notifier(struct cec_adapter *adap,
+					     struct cec_notifier *notifier)
+{
+}
+#endif
+
 #endif
 
 /**
-- 
1.9.1

[toc] | [next] | [standalone]

#1686307 — Re: [PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

On 10/07/17 17:46, Jose Abreu wrote:
> Add a new stub function for cec_register_cec_notifier() so that
> we can still call this function when CONFIG_CEC_NOTIFIER and
> CONFIG_CEC_CORE are not set.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> ---
>  include/media/cec.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/media/cec.h b/include/media/cec.h
> index 56643b2..8357f60 100644
> --- a/include/media/cec.h
> +++ b/include/media/cec.h
> @@ -365,6 +365,14 @@ static inline int cec_phys_addr_validate(u16 phys_addr, u16 *parent, u16 *port)
>  	return 0;
>  }
>  
> +#ifndef CONFIG_CEC_NOTIFIER
> +struct cec_notifier;
> +static inline void cec_register_cec_notifier(struct cec_adapter *adap,
> +					     struct cec_notifier *notifier)
> +{
> +}
> +#endif
> +
>  #endif
>  
>  /**
> 

This isn't quite right. This function prototype needs to be moved to cec-notifier.h.

I also saw that it isn't documented. I'll make a patch for this which will also include
documentation.

Regards,

	Hans

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web