Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684364 > unrolled thread

Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-10 17:40 +0200
    Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver Marek Vasut <marek.vasut@gmail.com> - 2017-07-17 22:50 +0200

#1684364 — Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

Hi Marek,

On Tue, May 2, 2017 at 2:18 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Add the MFD part of the ROHM BD9571MWV-M PMIC driver and MAINTAINERS
> entry. The MFD part only specifies the regmap bits for the PMIC and
> binds the subdevs together.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Lee Jones <lee.jones@linaro.org>

> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -133,6 +133,19 @@ config MFD_BCM590XX
>         help
>           Support for the BCM590xx PMUs from Broadcom
>
> +config MFD_BD9571MWV
> +       tristate "ROHM BD9571MWV PMIC"
> +       select MFD_CORE
> +       select REGMAP_I2C

Missing "select REGMAP_IRQ".

Else it fails with:

drivers/built-in.o: In function `bd9571mwv_remove':
:(.text+0x103190): undefined reference to `regmap_del_irq_chip'
drivers/built-in.o: In function `bd9571mwv_probe':
:(.text+0x10332c): undefined reference to `regmap_add_irq_chip'
:(.text+0x103358): undefined reference to `regmap_irq_get_domain'
:(.text+0x103394): undefined reference to `regmap_del_irq_chip'

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [next] | [standalone]

#1689451

On 07/10/2017 05:33 PM, Geert Uytterhoeven wrote:
> Hi Marek,
> 
> On Tue, May 2, 2017 at 2:18 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> Add the MFD part of the ROHM BD9571MWV-M PMIC driver and MAINTAINERS
>> entry. The MFD part only specifies the regmap bits for the PMIC and
>> binds the subdevs together.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Lee Jones <lee.jones@linaro.org>
> 
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -133,6 +133,19 @@ config MFD_BCM590XX
>>         help
>>           Support for the BCM590xx PMUs from Broadcom
>>
>> +config MFD_BD9571MWV
>> +       tristate "ROHM BD9571MWV PMIC"
>> +       select MFD_CORE
>> +       select REGMAP_I2C
> 
> Missing "select REGMAP_IRQ".
> 
> Else it fails with:

Added

-- 
Best regards,
Marek Vasut

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web