Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684149 > unrolled thread

[PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE

Back to article view | Back to linux.kernel

Contents

  [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE Arnd Bergmann <arnd@arndb.de> - 2017-07-10 13:30 +0200
    Re: [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE David Howells <dhowells@redhat.com> - 2017-07-11 17:30 +0200

#1684149 — [PATCH] 9p: hide cachetag option for non-CONFIG_9P_FSCACHE

show_options cannot print this option when it is disabled in Kconfig:

fs/9p/v9fs.c: In function 'v9fs_show_options':
fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?

Fixes: ccb0055985b9 ("9p: Implement show_options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/9p/v9fs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index d69046650a36..8fb89ddc6cc7 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -137,8 +137,10 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root)
 		seq_puts(m, ",nodevmap");
 	if (v9ses->cache)
 		seq_printf(m, ",%s", v9fs_cache_modes[v9ses->cache]);
+#ifdef CONFIG_9P_FSCACHE
 	if (v9ses->cachetag && v9ses->cache == CACHE_FSCACHE)
 		seq_printf(m, ",cachetag=%s", v9ses->cachetag);
+#endif
 
 	switch (v9ses->flags & V9FS_ACCESS_MASK) {
 	case V9FS_ACCESS_USER:
-- 
2.9.0

[toc] | [next] | [standalone]

#1685143

Arnd Bergmann <arnd@arndb.de> wrote:

> show_options cannot print this option when it is disabled in Kconfig:
> 
> fs/9p/v9fs.c: In function 'v9fs_show_options':
> fs/9p/v9fs.c:140:13: error: 'struct v9fs_session_info' has no member named 'cachetag'; did you mean 'cache'?
> 
> Fixes: ccb0055985b9 ("9p: Implement show_options")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David Howells <dhowells@redhat.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web