Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683978 > unrolled thread

[PATCHv3] staging: atomisp: use kstrdup to replace kmalloc and memcpy

Back to article view | Back to linux.kernel

Contents

  [PATCHv3] staging: atomisp: use kstrdup to replace kmalloc and memcpy Hari Prasath <gehariprasath@gmail.com> - 2017-07-10 08:20 +0200

#1683978 — [PATCHv3] staging: atomisp: use kstrdup to replace kmalloc and memcpy

kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.

Signed-off-by: Hari Prasath <gehariprasath@gmail.com>
---
	v1: Replace kmalloc followed by memcpy with kmemdup. Based on
	    review comments from Alan Cox, this could better be done
	    using kstrdup.
	v2: Replace kmalloc followed by memcpy by kstrdup in this case
	    as it essentially is a string copy.Review comment recieved
	    questioning the return value in case of error. Error value
	    returned should be what the calling function is expecting.
	v3: Retain the original error value returned to the calling
	    function if kstrdup() fails.
---
 .../staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c  | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
index 34cc56f..5d231ee 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
@@ -144,14 +144,10 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
 	)
 	{
 		char *namebuffer;
-		int namelength = (int)strlen(name);
 
-		namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);
-		if (namebuffer == NULL)
+		namebuffer = kstrdup(name, GFP_KERNEL);
+		if (!namebuffer)
 			return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
-
-		memcpy(namebuffer, name, namelength + 1);
-
 		bd->name = fw_minibuffer[index].name = namebuffer;
 	} else {
 		bd->name = name;
-- 
2.10.0.GIT

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web