Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683086 > unrolled thread

Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX  Controller Driver Jose Abreu <Jose.Abreu@synopsys.com> - 2017-07-07 11:40 +0200
    Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX  Controller Driver Hans Verkuil <hverkuil@xs4all.nl> - 2017-07-07 12:00 +0200

#1683086 — Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

On 06-07-2017 21:52, kbuild test robot wrote:
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit declaration of function 'v4l2_async_subnotifier_register' [-Werror=implicit-function-declaration]
>      return v4l2_async_subnotifier_register(&dw_dev->sd,
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_unregistered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1462:2: error: implicit declaration of function 'v4l2_async_subnotifier_unregister' [-Werror=implicit-function-declaration]
>      v4l2_async_subnotifier_unregister(&dw_dev->v4l2_notifier);

This one is expected. Required patch was not merged yet.

>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_parse_dt':
>    drivers/media//platform/dwc/dw-hdmi-rx.c:1555:22: warning: unused variable 'notifier' [-Wunused-variable]
>      struct device_node *notifier, *phy_node, *np = dw_dev->of_node;
>                          ^~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_rx_probe':
>    drivers/media//platform/dwc/dw-hdmi-rx.c:1765:1: warning: label 'err_phy' defined but not used [-Wunused-label]
>     err_phy:
>     ^~~~~~~
>    cc1: some warnings being treated as errors
>
>

These two is due to cec not being enabled. I hate to wrap this
around a #ifdef but is either this or extract cec to a separate
file, which I don't think is the best solution because the cec
code is quite small.

Best regards,
Jose Miguel Abreu

[toc] | [next] | [standalone]

#1683094

On 07/07/17 11:34, Jose Abreu wrote:
> On 06-07-2017 21:52, kbuild test robot wrote:
>>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered':
>>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit declaration of function 'v4l2_async_subnotifier_register' [-Werror=implicit-function-declaration]
>>      return v4l2_async_subnotifier_register(&dw_dev->sd,
>>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_unregistered':
>>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1462:2: error: implicit declaration of function 'v4l2_async_subnotifier_unregister' [-Werror=implicit-function-declaration]
>>      v4l2_async_subnotifier_unregister(&dw_dev->v4l2_notifier);
> 
> This one is expected. Required patch was not merged yet.
> 
>>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_parse_dt':
>>    drivers/media//platform/dwc/dw-hdmi-rx.c:1555:22: warning: unused variable 'notifier' [-Wunused-variable]
>>      struct device_node *notifier, *phy_node, *np = dw_dev->of_node;
>>                          ^~~~~~~~
>>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_rx_probe':
>>    drivers/media//platform/dwc/dw-hdmi-rx.c:1765:1: warning: label 'err_phy' defined but not used [-Wunused-label]
>>     err_phy:
>>     ^~~~~~~
>>    cc1: some warnings being treated as errors
>>
>>
> 
> These two is due to cec not being enabled. I hate to wrap this
> around a #ifdef but is either this or extract cec to a separate
> file, which I don't think is the best solution because the cec
> code is quite small.

The notifier functions can also be used if CEC_NOTIFIER isn't set.
See cec-notifier.h for the stub functions.

That will help somewhat.

Regards,

	Hans

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web