Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682810 > unrolled thread
| Started by | Shivappa Vikas <vikas.shivappa@intel.com> |
|---|---|
| First post | 2017-07-07 01:40 +0200 |
| Last post | 2017-07-07 08:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local) Shivappa Vikas <vikas.shivappa@intel.com> - 2017-07-07 01:40 +0200
Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local) Thomas Gleixner <tglx@linutronix.de> - 2017-07-07 08:50 +0200
| From | Shivappa Vikas <vikas.shivappa@intel.com> |
|---|---|
| Date | 2017-07-07 01:40 +0200 |
| Subject | Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local) |
| Message-ID | <u0oxj-3Ww-1@gated-at.bofh.it> |
On Sun, 2 Jul 2017, Thomas Gleixner wrote: >> INIT_LIST_HEAD(&r->evt_list); >> >> if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID)) >> list_add_tail(&llc_occupancy_event.list, &r->evt_list); >> + if (is_mbm_total_enabled()) >> + list_add_tail(&mbm_total_event.list, &r->evt_list); >> + if (is_mbm_local_enabled()) >> + list_add_tail(&mbm_local_event.list, &r->evt_list); > > Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why? They are really L3 resource events as per the spec. CPUID.(EAX=0FH, ECX=0):EDX.L3[bit 1] = 1 if L3 monitoring and we query for all the llc_occupancy, l3 total and local b/w with the same resource id 1. > > Thanks, > > tglx > > >
[toc] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2017-07-07 08:50 +0200 |
| Message-ID | <u0vfr-5W-7@gated-at.bofh.it> |
| In reply to | #1682810 |
On Thu, 6 Jul 2017, Shivappa Vikas wrote: > On Sun, 2 Jul 2017, Thomas Gleixner wrote: > > > INIT_LIST_HEAD(&r->evt_list); > > > > > > if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID)) > > > list_add_tail(&llc_occupancy_event.list, &r->evt_list); > > > + if (is_mbm_total_enabled()) > > > + list_add_tail(&mbm_total_event.list, &r->evt_list); > > > + if (is_mbm_local_enabled()) > > > + list_add_tail(&mbm_local_event.list, &r->evt_list); > > > > Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why? > > They are really L3 resource events as per the spec. > CPUID.(EAX=0FH, ECX=0):EDX.L3[bit 1] = 1 if L3 monitoring and we query for all > the llc_occupancy, l3 total and local b/w with the same resource id 1. Then this should be documented somewhere in the code ....
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web