Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680775 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-04 10:50 +0200 |
| Last post | 2017-07-07 06:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] target: make device_mutex and device_list static Colin King <colin.king@canonical.com> - 2017-07-04 10:50 +0200
Re: [PATCH] target: make device_mutex and device_list static Mike Christie <mchristi@redhat.com> - 2017-07-05 20:20 +0200
Re: [PATCH] target: make device_mutex and device_list static "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-07-07 06:40 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-04 10:50 +0200 |
| Subject | [PATCH] target: make device_mutex and device_list static |
| Message-ID | <tZrGW-5VQ-19@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com> Variables device_mutex and device_list static are local to the source, so make them static. Cleans up sparse warnings: "symbol 'device_list' was not declared. Should it be static?" "symbol 'device_mutex' was not declared. Should it be static?" Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/target/target_core_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 3ae8fbf01bdf..bbcef3bc66c8 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -49,8 +49,8 @@ #include "target_core_pr.h" #include "target_core_ua.h" -DEFINE_MUTEX(device_mutex); -LIST_HEAD(device_list); +static DEFINE_MUTEX(device_mutex); +static LIST_HEAD(device_list); static DEFINE_IDR(devices_idr); static struct se_hba *lun0_hba; -- 2.11.0
[toc] | [next] | [standalone]
| From | Mike Christie <mchristi@redhat.com> |
|---|---|
| Date | 2017-07-05 20:20 +0200 |
| Message-ID | <tZX46-1jQ-5@gated-at.bofh.it> |
| In reply to | #1680775 |
On 07/04/2017 03:44 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variables device_mutex and device_list static are local to the source, > so make them static. > > Cleans up sparse warnings: > "symbol 'device_list' was not declared. Should it be static?" > "symbol 'device_mutex' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/target/target_core_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > index 3ae8fbf01bdf..bbcef3bc66c8 100644 > --- a/drivers/target/target_core_device.c > +++ b/drivers/target/target_core_device.c > @@ -49,8 +49,8 @@ > #include "target_core_pr.h" > #include "target_core_ua.h" > > -DEFINE_MUTEX(device_mutex); > -LIST_HEAD(device_list); > +static DEFINE_MUTEX(device_mutex); > +static LIST_HEAD(device_list); > static DEFINE_IDR(devices_idr); > > static struct se_hba *lun0_hba; > My fault. Thanks. Reviewed-by: Mike Christie <mchristi@redhat.com>
[toc] | [prev] | [next] | [standalone]
| From | "Nicholas A. Bellinger" <nab@linux-iscsi.org> |
|---|---|
| Date | 2017-07-07 06:40 +0200 |
| Message-ID | <u0tdD-7dv-7@gated-at.bofh.it> |
| In reply to | #1681695 |
On Wed, 2017-07-05 at 13:15 -0500, Mike Christie wrote: > On 07/04/2017 03:44 AM, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > Variables device_mutex and device_list static are local to the source, > > so make them static. > > > > Cleans up sparse warnings: > > "symbol 'device_list' was not declared. Should it be static?" > > "symbol 'device_mutex' was not declared. Should it be static?" > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/target/target_core_device.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c > > index 3ae8fbf01bdf..bbcef3bc66c8 100644 > > --- a/drivers/target/target_core_device.c > > +++ b/drivers/target/target_core_device.c > > @@ -49,8 +49,8 @@ > > #include "target_core_pr.h" > > #include "target_core_ua.h" > > > > -DEFINE_MUTEX(device_mutex); > > -LIST_HEAD(device_list); > > +static DEFINE_MUTEX(device_mutex); > > +static LIST_HEAD(device_list); > > static DEFINE_IDR(devices_idr); > > > > static struct se_hba *lun0_hba; > > > > My fault. Thanks. > > Reviewed-by: Mike Christie <mchristi@redhat.com> Applied. Thanks Colin + MNC.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web