Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682207 > unrolled thread
| Started by | Corentin Labbe <clabbe.montjoie@gmail.com> |
|---|---|
| First post | 2017-07-06 11:00 +0200 |
| Last post | 2017-07-06 21:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-06 11:00 +0200
Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-06 21:00 +0200
Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-07-06 21:10 +0200
| From | Corentin Labbe <clabbe.montjoie@gmail.com> |
|---|---|
| Date | 2017-07-06 11:00 +0200 |
| Subject | [PATCH] ARM: sunxi: h3/h5: Correct emac register size |
| Message-ID | <u0aNI-1Z7-19@gated-at.bofh.it> |
The datasheet said that emac register size is 0x1000 not 0x104
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 716e7d668dec..5a57b67c9b77 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -406,7 +406,7 @@
emac: ethernet@1c30000 {
compatible = "allwinner,sun8i-h3-emac";
syscon = <&syscon>;
- reg = <0x01c30000 0x104>;
+ reg = <0x01c30000 0x1000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq";
resets = <&ccu RST_BUS_EMAC>;
--
2.13.0
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-07-06 21:00 +0200 |
| Message-ID | <u0kal-RF-5@gated-at.bofh.it> |
| In reply to | #1682207 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> The datasheet said that emac register size is 0x1000 not 0x104
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 716e7d668dec..5a57b67c9b77 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -406,7 +406,7 @@
> emac: ethernet@1c30000 {
> compatible = "allwinner,sun8i-h3-emac";
> syscon = <&syscon>;
> - reg = <0x01c30000 0x104>;
> + reg = <0x01c30000 0x1000>;
The size is actually 0x10000. I fixed it and applied.
The A64 DTSI has the same issue, can you send a patch for this one
too?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Corentin Labbe <clabbe.montjoie@gmail.com> |
|---|---|
| Date | 2017-07-06 21:10 +0200 |
| Message-ID | <u0kk1-1aq-19@gated-at.bofh.it> |
| In reply to | #1682651 |
On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> > emac: ethernet@1c30000 {
> > compatible = "allwinner,sun8i-h3-emac";
> > syscon = <&syscon>;
> > - reg = <0x01c30000 0x104>;
> > + reg = <0x01c30000 0x1000>;
>
> The size is actually 0x10000. I fixed it and applied.
>
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
>
Yes
Thanks for the fixing
Regards
Corentin Labbe
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web