Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682364 > unrolled thread
| Started by | Dmitry Tunin <hanipouspilot@gmail.com> |
|---|---|
| First post | 2017-07-06 13:40 +0200 |
| Last post | 2017-07-16 10:30 +0200 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin <hanipouspilot@gmail.com> - 2017-07-06 13:40 +0200
Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin <hanipouspilot@gmail.com> - 2017-07-06 13:50 +0200
Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices Marcel Holtmann <marcel@holtmann.org> - 2017-07-16 09:20 +0200
Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin <hanipouspilot@gmail.com> - 2017-07-16 10:00 +0200
Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices Dmitry Tunin <hanipouspilot@gmail.com> - 2017-07-16 10:00 +0200
Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices Marcel Holtmann <marcel@holtmann.org> - 2017-07-16 10:30 +0200
| From | Dmitry Tunin <hanipouspilot@gmail.com> |
|---|---|
| Date | 2017-07-06 13:40 +0200 |
| Subject | [PATCH] Add support of all Foxconn (105b) Broadcom devices |
| Message-ID | <u0dix-3HN-5@gated-at.bofh.it> |
There is another device
T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=105b ProdID=e066 Rev=01.12
S: Manufacturer=Broadcom Corp
S: Product=BCM20702A0
S: SerialNumber=342387DAE35E
C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
Since we have Cls=ff, we can add all of them.
Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
Cc: stable@vger.kernel.org
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fa24d69..bf95c13 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
{ USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
/* Broadcom BCM43142A0 (Foxconn/Lenovo) */
- { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
+ { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
/* Broadcom BCM920703 (HTC Vive) */
{ USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
--
2.7.4
[toc] | [next] | [standalone]
| From | Dmitry Tunin <hanipouspilot@gmail.com> |
|---|---|
| Date | 2017-07-06 13:50 +0200 |
| Message-ID | <u0dse-3Lz-19@gated-at.bofh.it> |
| In reply to | #1682364 |
I lost a line here. Sending v2.
2017-07-06 14:29 GMT+03:00 Dmitry Tunin <hanipouspilot@gmail.com>:
> There is another device
>
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=105b ProdID=e066 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=342387DAE35E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Since we have Cls=ff, we can add all of them.
>
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fa24d69..bf95c13 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>
> /* Broadcom BCM920703 (HTC Vive) */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
> --
> 2.7.4
>
[toc] | [prev] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-07-16 09:20 +0200 |
| Message-ID | <u3M0p-44x-13@gated-at.bofh.it> |
| In reply to | #1682364 |
Hi Dmitry,
> There is another device
>
> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=105b ProdID=e066 Rev=01.12
> S: Manufacturer=Broadcom Corp
> S: Product=BCM20702A0
> S: SerialNumber=342387DAE35E
> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>
> Since we have Cls=ff, we can add all of them.
>
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fa24d69..bf95c13 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>
> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>
> /* Broadcom BCM920703 (HTC Vive) */
> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
Regards
Marcel
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Tunin <hanipouspilot@gmail.com> |
|---|---|
| Date | 2017-07-16 10:00 +0200 |
| Message-ID | <u3MD7-4h1-1@gated-at.bofh.it> |
| In reply to | #1688141 |
The one that is in your tree is correct. I see the problem. I added
the Cc: stable... to the first one and it got through there.
My apologies, I received the patch by mail and forwarded it. In a
second I found out the crap and fixed it.
2017-07-16 10:15 GMT+03:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Dmitry,
>
>> There is another device
>>
>> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=105b ProdID=e066 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=342387DAE35E
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Since we have Cls=ff, we can add all of them.
>>
>> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
>> Cc: stable@vger.kernel.org
>> ---
>> drivers/bluetooth/btusb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index fa24d69..bf95c13 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
>> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>>
>> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
>> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
>> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>>
>> /* Broadcom BCM920703 (HTC Vive) */
>> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
>
> this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
>
> Regards
>
> Marcel
>
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Tunin <hanipouspilot@gmail.com> |
|---|---|
| Date | 2017-07-16 10:00 +0200 |
| Message-ID | <u3MD7-4h1-7@gated-at.bofh.it> |
| In reply to | #1688141 |
Hi Marcel,
This one https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
is really garbled. But I wrote to you in a couple of minutes after I
sent it. And then sent the v2.
It looks like you applied a wrong one.
Regards,
Dmitry
2017-07-16 10:15 GMT+03:00 Marcel Holtmann <marcel@holtmann.org>:
> Hi Dmitry,
>
>> There is another device
>>
>> T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
>> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=105b ProdID=e066 Rev=01.12
>> S: Manufacturer=Broadcom Corp
>> S: Product=BCM20702A0
>> S: SerialNumber=342387DAE35E
>> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Since we have Cls=ff, we can add all of them.
>>
>> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
>> Cc: stable@vger.kernel.org
>> ---
>> drivers/bluetooth/btusb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index fa24d69..bf95c13 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
>> { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>>
>> /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
>> - { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
>> + { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>>
>> /* Broadcom BCM920703 (HTC Vive) */
>> { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
>
> this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
>
> Regards
>
> Marcel
>
[toc] | [prev] | [next] | [standalone]
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Date | 2017-07-16 10:30 +0200 |
| Message-ID | <u3N6a-4FO-7@gated-at.bofh.it> |
| In reply to | #1688157 |
Hi Dmitry, > This one https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656 > is really garbled. But I wrote to you in a couple of minutes after I > sent it. And then sent the v2. > It looks like you applied a wrong one. funny. It popped up on the top of my inbox due to the 0day kbot picking it up now (10 days later) for some reason. Regards Marcel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web