Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682181 > unrolled thread

[PATCH] ptp: dte: Use LL suffix for 64-bit constants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ptp: dte: Use LL suffix for 64-bit constants Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-06 10:40 +0200
    Re: [PATCH] ptp: dte: Use LL suffix for 64-bit constants David Miller <davem@davemloft.net> - 2017-07-06 12:50 +0200

#1682181 — [PATCH] ptp: dte: Use LL suffix for 64-bit constants

With gcc 4.1.2:

    drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’:
    drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for ‘long’ type
    drivers/ptp/ptp_dte.c:112: warning: integer constant is too large for ‘long’ type
    drivers/ptp/ptp_dte.c:114: warning: integer constant is too large for ‘long’ type

Add the missing "LL" suffix to fix this.

Fixes: 8a56aa107f1e8123 ("ptp: Add a ptp clock driver for Broadcom DTE")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ptp/ptp_dte.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_dte.c b/drivers/ptp/ptp_dte.c
index 00145a3f1e707451..faf6f7a837137408 100644
--- a/drivers/ptp/ptp_dte.c
+++ b/drivers/ptp/ptp_dte.c
@@ -40,7 +40,7 @@
 #define DTE_WRAP_AROUND_NSEC_SHIFT 44
 
 /* 44 bits NCO */
-#define DTE_NCO_MAX_NS	0xFFFFFFFFFFF
+#define DTE_NCO_MAX_NS	0xFFFFFFFFFFFLL
 
 /* 125MHz with 3.29 reg cfg */
 #define DTE_PPB_ADJ(ppb) (u32)(div64_u64((((u64)abs(ppb) * BIT(28)) +\
-- 
2.7.4

[toc] | [next] | [standalone]

#1682335

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  6 Jul 2017 10:34:54 +0200

> With gcc 4.1.2:
> 
>     drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’:
>     drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for ‘long’ type
>     drivers/ptp/ptp_dte.c:112: warning: integer constant is too large for ‘long’ type
>     drivers/ptp/ptp_dte.c:114: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "LL" suffix to fix this.
> 
> Fixes: 8a56aa107f1e8123 ("ptp: Add a ptp clock driver for Broadcom DTE")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web