Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683483 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-07-08 02:40 +0200 |
| Last post | 2017-07-17 06:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-08 02:40 +0200
Re: [PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure Guenter Roeck <linux@roeck-us.net> - 2017-07-08 03:50 +0200
Re: [PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 06:10 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-08 02:40 +0200 |
| Subject | [PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure |
| Message-ID | <u0LWW-3li-13@gated-at.bofh.it> |
Check for watchdog_ops structures that are only stored in the ops field of
a watchdog_device structure. This field is declared const, so watchdog_ops
structures that have this property can be declared as const also.
This issue was detected using Coccinelle and the following semantic patch:
@r
disable optional_qualifier@
identifier i;
position p;
@@
static struct watchdog_ops i@p = { ... };
@ok@
identifier r.i;
struct watchdog_device e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct watchdog_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct watchdog_ops i = { ... };
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/watchdog/coh901327_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index 38dd60f0..4410337 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -218,7 +218,7 @@ static const struct watchdog_info coh901327_ident = {
.identity = DRV_NAME,
};
-static struct watchdog_ops coh901327_ops = {
+static const struct watchdog_ops coh901327_ops = {
.owner = THIS_MODULE,
.start = coh901327_start,
.stop = coh901327_stop,
--
2.5.0
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-07-08 03:50 +0200 |
| Message-ID | <u0N2G-43B-15@gated-at.bofh.it> |
| In reply to | #1683483 |
On 07/07/2017 05:33 PM, Gustavo A. R. Silva wrote:
> Check for watchdog_ops structures that are only stored in the ops field of
> a watchdog_device structure. This field is declared const, so watchdog_ops
> structures that have this property can be declared as const also.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @r
> disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct watchdog_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct watchdog_device e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct watchdog_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct watchdog_ops i = { ... };
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/coh901327_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 38dd60f0..4410337 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -218,7 +218,7 @@ static const struct watchdog_info coh901327_ident = {
> .identity = DRV_NAME,
> };
>
> -static struct watchdog_ops coh901327_ops = {
> +static const struct watchdog_ops coh901327_ops = {
> .owner = THIS_MODULE,
> .start = coh901327_start,
> .stop = coh901327_stop,
>
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-17 06:10 +0200 |
| Message-ID | <u45w6-8uY-9@gated-at.bofh.it> |
| In reply to | #1683510 |
On 07/07/2017 08:45 PM, Guenter Roeck wrote:
> On 07/07/2017 05:33 PM, Gustavo A. R. Silva wrote:
>> Check for watchdog_ops structures that are only stored in the ops
>> field of
>> a watchdog_device structure. This field is declared const, so
>> watchdog_ops
>> structures that have this property can be declared as const also.
>>
>> This issue was detected using Coccinelle and the following semantic
>> patch:
>>
>> @r
>> disable optional_qualifier@
>> identifier i;
>> position p;
>> @@
>> static struct watchdog_ops i@p = { ... };
>>
>> @ok@
>> identifier r.i;
>> struct watchdog_device e;
>> position p;
>> @@
>> e.ops = &i@p;
>>
>> @bad@
>> position p != {r.p,ok.p};
>> identifier r.i;
>> struct watchdog_ops e;
>> @@
>> e@i@p
>>
>> @depends on !bad disable optional_qualifier@
>> identifier r.i;
>> @@
>> static
>> +const
>> struct watchdog_ops i = { ... };
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thank you, Guenter.
>> ---
>> drivers/watchdog/coh901327_wdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/coh901327_wdt.c
>> b/drivers/watchdog/coh901327_wdt.c
>> index 38dd60f0..4410337 100644
>> --- a/drivers/watchdog/coh901327_wdt.c
>> +++ b/drivers/watchdog/coh901327_wdt.c
>> @@ -218,7 +218,7 @@ static const struct watchdog_info coh901327_ident
>> = {
>> .identity = DRV_NAME,
>> };
>> -static struct watchdog_ops coh901327_ops = {
>> +static const struct watchdog_ops coh901327_ops = {
>> .owner = THIS_MODULE,
>> .start = coh901327_start,
>> .stop = coh901327_stop,
>>
>
--
Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web