Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682073 > unrolled thread
| Started by | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| First post | 2017-07-06 08:50 +0200 |
| Last post | 2017-07-06 09:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM Thierry Reding <thierry.reding@gmail.com> - 2017-07-06 08:50 +0200
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-06 09:10 +0200
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-06 09:10 +0200
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2017-07-06 08:50 +0200 |
| Subject | Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM |
| Message-ID | <u08LT-OV-1@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > Switch to atomic PWM. The main goal is to properly wait for a period before > disabling a channel to ensure the correct level is set on the output. > > Changes in v2: > - fixed remaining checkpatch warnings > - split the series to ease reviews > - changed the delay handling to ensure the proper amount of time has elapsed > before disabling a channel > - dropped RDY bit handling as it doesn't have any real effect. > > Alexandre Belloni (3): > pwm: sun4i: improve hardware read out > pwm: sun4i: switch to atomic PWM > pwm: sun4i: drop legacy callbacks > > drivers/pwm/pwm-sun4i.c | 263 +++++++++++++++++++++++++++--------------------- > 1 file changed, 148 insertions(+), 115 deletions(-) Series applied, though you could've just squashed together patches 2 and 3 because they don't make sense apart. Thierry
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-07-06 09:10 +0200 |
| Message-ID | <u095f-1az-9@gated-at.bofh.it> |
| In reply to | #1682073 |
On Thu, 6 Jul 2017 09:00:16 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote: > > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > > > Switch to atomic PWM. The main goal is to properly wait for a period before > > > disabling a channel to ensure the correct level is set on the output. > > > > > > Changes in v2: > > > - fixed remaining checkpatch warnings > > > - split the series to ease reviews > > > - changed the delay handling to ensure the proper amount of time has elapsed > > > before disabling a channel > > > - dropped RDY bit handling as it doesn't have any real effect. > > > > > > Alexandre Belloni (3): > > > pwm: sun4i: improve hardware read out > > > pwm: sun4i: switch to atomic PWM > > > pwm: sun4i: drop legacy callbacks > > > > > > drivers/pwm/pwm-sun4i.c | 263 +++++++++++++++++++++++++++--------------------- > > > 1 file changed, 148 insertions(+), 115 deletions(-) > > > > Series applied, though you could've just squashed together patches 2 and > > 3 because they don't make sense apart. > > > > Ok, thanks. IIRC, Boris suggested the split ;) Yes, I did it because the diff was really hard to review.
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-07-06 09:10 +0200 |
| Message-ID | <u095f-1az-11@gated-at.bofh.it> |
| In reply to | #1682073 |
On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote: > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > > Switch to atomic PWM. The main goal is to properly wait for a period before > > disabling a channel to ensure the correct level is set on the output. > > > > Changes in v2: > > - fixed remaining checkpatch warnings > > - split the series to ease reviews > > - changed the delay handling to ensure the proper amount of time has elapsed > > before disabling a channel > > - dropped RDY bit handling as it doesn't have any real effect. > > > > Alexandre Belloni (3): > > pwm: sun4i: improve hardware read out > > pwm: sun4i: switch to atomic PWM > > pwm: sun4i: drop legacy callbacks > > > > drivers/pwm/pwm-sun4i.c | 263 +++++++++++++++++++++++++++--------------------- > > 1 file changed, 148 insertions(+), 115 deletions(-) > > Series applied, though you could've just squashed together patches 2 and > 3 because they don't make sense apart. > Ok, thanks. IIRC, Boris suggested the split ;) > Thierry -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web