Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681945 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2017-07-06 01:50 +0200 |
| Last post | 2017-07-06 12:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static kbuild test robot <fengguang.wu@intel.com> - 2017-07-06 01:50 +0200
Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static Stephen Rothwell <sfr@canb.auug.org.au> - 2017-07-06 02:30 +0200
Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static Fengguang Wu <fengguang.wu@intel.com> - 2017-07-06 11:00 +0200
Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static David Miller <davem@davemloft.net> - 2017-07-06 12:00 +0200
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2017-07-06 01:50 +0200 |
| Subject | [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static |
| Message-ID | <u02dr-4D2-1@gated-at.bofh.it> |
Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
tcp_ipv4.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 6ec6900..a20e7f0 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
}
EXPORT_SYMBOL(tcp_md5_do_lookup);
-struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
- const union tcp_md5_addr *addr,
- int family, u8 prefixlen)
+static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
+ const union tcp_md5_addr *addr,
+ int family, u8 prefixlen)
{
const struct tcp_sock *tp = tcp_sk(sk);
struct tcp_md5sig_key *key;
[toc] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-07-06 02:30 +0200 |
| Subject | Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static |
| Message-ID | <u02Qa-5ct-11@gated-at.bofh.it> |
| In reply to | #1681945 |
Hi,
Not sure why you sent this to me ... it fixes a commit in the net-next
tree (now in Linus' tree) ...
On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>
> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")
Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> tcp_ipv4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 6ec6900..a20e7f0 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
> }
> EXPORT_SYMBOL(tcp_md5_do_lookup);
>
> -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> - const union tcp_md5_addr *addr,
> - int family, u8 prefixlen)
> +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
> + const union tcp_md5_addr *addr,
> + int family, u8 prefixlen)
> {
> const struct tcp_sock *tp = tcp_sk(sk);
> struct tcp_md5sig_key *key;
--
Cheers,
Stephen Rothwell
[toc] | [prev] | [next] | [standalone]
| From | Fengguang Wu <fengguang.wu@intel.com> |
|---|---|
| Date | 2017-07-06 11:00 +0200 |
| Subject | Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static |
| Message-ID | <u0aNI-1Z7-27@gated-at.bofh.it> |
| In reply to | #1681971 |
Hi Stephen,
On Thu, Jul 06, 2017 at 10:27:12AM +1000, Stephen Rothwell wrote:
>Hi,
>
>Not sure why you sent this to me ... it fixes a commit in the net-next
>tree (now in Linus' tree) ...
Yeah sorry -- it's a bug in the robot.
>On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>>
>> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")
>
>Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")
Yeah, fixed the robot. Thank you for the reminder!
Regards,
Fengguang
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>> tcp_ipv4.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
>> index 6ec6900..a20e7f0 100644
>> --- a/net/ipv4/tcp_ipv4.c
>> +++ b/net/ipv4/tcp_ipv4.c
>> @@ -943,9 +943,9 @@ struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
>> }
>> EXPORT_SYMBOL(tcp_md5_do_lookup);
>>
>> -struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
>> - const union tcp_md5_addr *addr,
>> - int family, u8 prefixlen)
>> +static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk,
>> + const union tcp_md5_addr *addr,
>> + int family, u8 prefixlen)
>> {
>> const struct tcp_sock *tp = tcp_sk(sk);
>> struct tcp_md5sig_key *key;
>
>--
>Cheers,
>Stephen Rothwell
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-06 12:00 +0200 |
| Subject | Re: [RFC PATCH linus] tcp: md5: tcp_md5_do_lookup_exact() can be static |
| Message-ID | <u0bJN-2Bf-33@gated-at.bofh.it> |
| In reply to | #1681971 |
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 6 Jul 2017 10:27:12 +1000
> Hi,
>
> Not sure why you sent this to me ... it fixes a commit in the net-next
> tree (now in Linus' tree) ...
>
> On Thu, 6 Jul 2017 07:58:53 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
>>
>> Fixes: 0c5f0311f690 ("Add linux-next specific files for 20170705")
>
> Actually: Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")
Applied with correct fixes tag, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web