Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628919 > unrolled thread
| Started by | Pan Bian <bianpan2016@163.com> |
|---|---|
| First post | 2017-04-23 09:20 +0200 |
| Last post | 2017-04-24 22:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] tipc: check return value of nlmsg_new Pan Bian <bianpan2016@163.com> - 2017-04-23 09:20 +0200
RE: [PATCH 1/1] tipc: check return value of nlmsg_new Jon Maloy <jon.maloy@ericsson.com> - 2017-04-23 15:40 +0200
Re: [PATCH 1/1] tipc: check return value of nlmsg_new David Miller <davem@davemloft.net> - 2017-04-24 22:00 +0200
| From | Pan Bian <bianpan2016@163.com> |
|---|---|
| Date | 2017-04-23 09:20 +0200 |
| Subject | [PATCH 1/1] tipc: check return value of nlmsg_new |
| Message-ID | <tzjYm-5pv-5@gated-at.bofh.it> |
Function nlmsg_new() will return a NULL pointer if there is no enough memory, and its return value should be checked before it is used. However, in function tipc_nl_node_get_monitor(), the validation of the return value of function nlmsg_new() is missed. This patch fixes the bug. Signed-off-by: Pan Bian <bianpan2016@163.com> --- net/tipc/node.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/node.c b/net/tipc/node.c index 4512e83..568e48d 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -2098,6 +2098,8 @@ int tipc_nl_node_get_monitor(struct sk_buff *skb, struct genl_info *info) int err; msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); + if (!msg.skb) + return -ENOMEM; msg.portid = info->snd_portid; msg.seq = info->snd_seq; -- 1.9.1
[toc] | [next] | [standalone]
| From | Jon Maloy <jon.maloy@ericsson.com> |
|---|---|
| Date | 2017-04-23 15:40 +0200 |
| Message-ID | <tzpU5-Fe-3@gated-at.bofh.it> |
| In reply to | #1628919 |
Acknowledged. Thank you for doing this job. ///jon > -----Original Message----- > From: Pan Bian [mailto:bianpan2016@163.com] > Sent: Sunday, April 23, 2017 03:09 AM > To: Jon Maloy <jon.maloy@ericsson.com>; Ying Xue > <ying.xue@windriver.com>; David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux- > kernel@vger.kernel.org; Pan Bian <bianpan2016@163.com> > Subject: [PATCH 1/1] tipc: check return value of nlmsg_new > > Function nlmsg_new() will return a NULL pointer if there is no enough > memory, and its return value should be checked before it is used. > However, in function tipc_nl_node_get_monitor(), the validation of the > return value of function nlmsg_new() is missed. This patch fixes the bug. > > Signed-off-by: Pan Bian <bianpan2016@163.com> > --- > net/tipc/node.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/tipc/node.c b/net/tipc/node.c index 4512e83..568e48d 100644 > --- a/net/tipc/node.c > +++ b/net/tipc/node.c > @@ -2098,6 +2098,8 @@ int tipc_nl_node_get_monitor(struct sk_buff *skb, > struct genl_info *info) > int err; > > msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); > + if (!msg.skb) > + return -ENOMEM; > msg.portid = info->snd_portid; > msg.seq = info->snd_seq; > > -- > 1.9.1 >
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-04-24 22:00 +0200 |
| Message-ID | <tzSjp-2Lp-55@gated-at.bofh.it> |
| In reply to | #1628919 |
From: Pan Bian <bianpan2016@163.com> Date: Sun, 23 Apr 2017 15:09:19 +0800 > Function nlmsg_new() will return a NULL pointer if there is no enough > memory, and its return value should be checked before it is used. > However, in function tipc_nl_node_get_monitor(), the validation of the > return value of function nlmsg_new() is missed. This patch fixes the > bug. > > Signed-off-by: Pan Bian <bianpan2016@163.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web