Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629024 > unrolled thread

[PATCH 1/1] cfg80211: add return value validation

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] cfg80211: add return value validation Pan Bian <bianpan201603@163.com> - 2017-04-23 15:30 +0200
    Re: [PATCH 1/1] cfg80211: add return value validation Johannes Berg <johannes@sipsolutions.net> - 2017-04-23 20:50 +0200

#1629024 — [PATCH 1/1] cfg80211: add return value validation

From: Pan Bian <bianpan2016@163.com>

Function create_singlethread_workqueue() will return a NULL pointer if
there is no enough memory, and its return value should be validated
before using. However, in function rndis_wlan_bind(), its return value
is not checked. This may cause NULL dereference bugs. This patch fixes
it.

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/net/wireless/rndis_wlan.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 785334f..92a1bde 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -3427,6 +3427,10 @@ static int rndis_wlan_bind(struct usbnet *usbdev, struct usb_interface *intf)
 
 	/* because rndis_command() sleeps we need to use workqueue */
 	priv->workqueue = create_singlethread_workqueue("rndis_wlan");
+	if (!priv->workqueue) {
+		wiphy_free(wiphy);
+		return -ENOMEM;
+	}
 	INIT_WORK(&priv->work, rndis_wlan_worker);
 	INIT_DELAYED_WORK(&priv->dev_poller_work, rndis_device_poller);
 	INIT_DELAYED_WORK(&priv->scan_work, rndis_get_scan_results);
-- 
1.9.1

[toc] | [next] | [standalone]

#1629063

This is not a cfg80211 patch, please resend with the correct subject.

Thanks,
johannes

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web