Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1630106 > unrolled thread

[PATCH v2 1/2] of: support dtc compiler flags for overlays

Started byfrowand.list@gmail.com
First post2017-04-25 01:10 +0200
Last post2017-04-26 02:20 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2 1/2] of: support dtc compiler flags for overlays frowand.list@gmail.com - 2017-04-25 01:10 +0200
    Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-26 00:10 +0200
      Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays Frank Rowand <frowand.list@gmail.com> - 2017-04-26 02:20 +0200

#1630106 — [PATCH v2 1/2] of: support dtc compiler flags for overlays

Fromfrowand.list@gmail.com
Date2017-04-25 01:10 +0200
Subject[PATCH v2 1/2] of: support dtc compiler flags for overlays
Message-ID<tzVhf-4Us-7@gated-at.bofh.it>
From: Frank Rowand <frank.rowand@sony.com>

The dtc compiler version that adds initial support was available
in 4.11-rc1.  Add the ability to set the dtc compiler flags needed
by overlays.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
 scripts/Makefile.lib | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 0a07f9014944..0bbec480d323 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
 DTC_FLAGS += -Wno-unit_address_vs_reg
 endif
 
+DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
+
 # Generate an assembly file to wrap the output of the device tree compiler
 quiet_cmd_dt_S_dtb= DTB     $@
 cmd_dt_S_dtb=						\
-- 
Frank Rowand <frank.rowand@sony.com>

[toc] | [next] | [standalone]


#1631028

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-04-26 00:10 +0200
Message-ID<tAgOJ-23i-11@gated-at.bofh.it>
In reply to#1630106
2017-04-25 8:05 GMT+09:00  <frowand.list@gmail.com>:
> From: Frank Rowand <frank.rowand@sony.com>
>
> The dtc compiler version that adds initial support was available
> in 4.11-rc1.  Add the ability to set the dtc compiler flags needed
> by overlays.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---


I know your motivation for 1/2 is overlay,
but this patch itself is more generic.
(support for per-file dtc compiler flag)

Could you reword the commit subject a little bit?

Otherwise,

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>



>  scripts/Makefile.lib | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 0a07f9014944..0bbec480d323 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
>  DTC_FLAGS += -Wno-unit_address_vs_reg
>  endif
>
> +DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
> +
>  # Generate an assembly file to wrap the output of the device tree compiler
>  quiet_cmd_dt_S_dtb= DTB     $@
>  cmd_dt_S_dtb=                                          \
> --


-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]


#1631071

FromFrank Rowand <frowand.list@gmail.com>
Date2017-04-26 02:20 +0200
Message-ID<tAiQy-3gC-17@gated-at.bofh.it>
In reply to#1631028
On 04/25/17 15:04, Masahiro Yamada wrote:
> 2017-04-25 8:05 GMT+09:00  <frowand.list@gmail.com>:
>> From: Frank Rowand <frank.rowand@sony.com>
>>
>> The dtc compiler version that adds initial support was available
>> in 4.11-rc1.  Add the ability to set the dtc compiler flags needed
>> by overlays.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>> ---
> 
> 
> I know your motivation for 1/2 is overlay,
> but this patch itself is more generic.
> (support for per-file dtc compiler flag)
> 
> Could you reword the commit subject a little bit?
> 
> Otherwise,
> 
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Fixed in version 4.

-Frank

> 
> 
> 
>>  scripts/Makefile.lib | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 0a07f9014944..0bbec480d323 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
>>  DTC_FLAGS += -Wno-unit_address_vs_reg
>>  endif
>>
>> +DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
>> +
>>  # Generate an assembly file to wrap the output of the device tree compiler
>>  quiet_cmd_dt_S_dtb= DTB     $@
>>  cmd_dt_S_dtb=                                          \
>> --
> 
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web