Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629836 > unrolled thread

PATCH drivers:net:cris/eth_v10: alternate string char arrary

Back to article view | Back to linux.kernel

Contents

  PATCH drivers:net:cris/eth_v10: alternate string char arrary Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-24 20:00 +0200
    Re: PATCH drivers:net:cris/eth_v10: alternate string char arrary David Miller <davem@davemloft.net> - 2017-04-24 20:30 +0200
    RE:PATCH drivers:net:cris/eth_v10: alternate string char arrary Karim Eshapa <karim.eshapa@gmail.com> - 2017-04-24 22:00 +0200
      Re: PATCH drivers:net:cris/eth_v10: alternate string char arrary David Miller <davem@davemloft.net> - 2017-04-24 22:10 +0200

#1629836 — PATCH drivers:net:cris/eth_v10: alternate string char arrary

static char pointer creates two variables in final assembly.
static string and pointer to it according to
Jeff Garzik janitors TODO.

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
 drivers/net/cris/eth_v10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c
index 91c876a..370765f 100644
--- a/drivers/net/cris/eth_v10.c
+++ b/drivers/net/cris/eth_v10.c
@@ -44,7 +44,7 @@
  * io regions, irqs and dma channels
  */
 
-static const char* cardname = "ETRAX 100LX built-in ethernet controller";
+static const char cardname[] = "ETRAX 100LX built-in ethernet controller";
 
 /* A default ethernet address. Highlevel SW will set the real one later */
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1629880

From: Karim Eshapa <karim.eshapa@gmail.com>
Date: Mon, 24 Apr 2017 19:49:39 +0200

> static char pointer creates two variables in final assembly.
> static string and pointer to it according to
> Jeff Garzik janitors TODO.
> 
> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>

Instead of trusting some document written more than 10 years ago on
the internet, why don't you build the source file in question and take
a look at what actually happens?

I'm not applying this, sorry.

[toc] | [prev] | [next] | [standalone]

#1629934

On  Mon, 24 Apr 2017 14:18:58 -0400 (EDT), David Miller wrote:
> Mon, 24 Apr 2017 19:49:39 +0200, Karim Eshapa wrote:
>>
>> static char pointer creates two variables in final assembly.
>> static string and pointer to it according to
>> Jeff Garzik janitors TODO.
>
> Instead of trusting some document written more than 10 years ago on
> the internet, why don't you build the source file in question and take
> a look at what actually happens?
>

I've just dumped the assembly and symbols. I didn't find 
extraordinary difference between the two strings.
sorry for that, but why is that still there in 
TODO kerneljanitors at kernelnewbies.

Thanks,
Karim

[toc] | [prev] | [next] | [standalone]

#1629959

From: Karim Eshapa <karim.eshapa@gmail.com>
Date: Mon, 24 Apr 2017 21:54:42 +0200

> On  Mon, 24 Apr 2017 14:18:58 -0400 (EDT), David Miller wrote:
>> Mon, 24 Apr 2017 19:49:39 +0200, Karim Eshapa wrote:
>>>
>>> static char pointer creates two variables in final assembly.
>>> static string and pointer to it according to
>>> Jeff Garzik janitors TODO.
>>
>> Instead of trusting some document written more than 10 years ago on
>> the internet, why don't you build the source file in question and take
>> a look at what actually happens?
>>
> 
> I've just dumped the assembly and symbols. I didn't find 
> extraordinary difference between the two strings.
> sorry for that, but why is that still there in 
> TODO kerneljanitors at kernelnewbies.

Because nobody is updating the documentation.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web