Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628211 > unrolled thread
| Started by | Anders Darander <anders@chargestorm.se> |
|---|---|
| First post | 2017-04-21 14:50 +0200 |
| Last post | 2017-04-24 18:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x Anders Darander <anders@chargestorm.se> - 2017-04-21 14:50 +0200
[PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x Anders Darander <anders@chargestorm.se> - 2017-04-21 14:50 +0200
Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x Linus Walleij <linus.walleij@linaro.org> - 2017-04-24 18:40 +0200
Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-26 10:00 +0200
Re: [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x Linus Walleij <linus.walleij@linaro.org> - 2017-04-24 18:30 +0200
| From | Anders Darander <anders@chargestorm.se> |
|---|---|
| Date | 2017-04-21 14:50 +0200 |
| Subject | [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x |
| Message-ID | <tyGaC-5Ri-7@gated-at.bofh.it> |
The TCA9554 doesn't work with the pcf857x driver, trying to change the direction
gives a NAK bailout error.
TCA9554 is similar to the PCA9554, thus change the driver.
Signed-off-by: Anders Darander <anders@chargestorm.se>
---
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-pca953x.c | 1 +
drivers/gpio/gpio-pcf857x.c | 2 --
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 05043071fc98..684f887173e9 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -753,7 +753,7 @@ config GPIO_PCA953X
4 bits: pca9536, pca9537
8 bits: max7310, max7315, pca6107, pca9534, pca9538, pca9554,
- pca9556, pca9557, pca9574, tca6408, xra1202
+ pca9556, pca9557, pca9574, tca6408, tca9554, xra1202
16 bits: max7312, max7313, pca9535, pca9539, pca9555, pca9575,
tca6416
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d44232aadb6c..13d895264fc8 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -81,6 +81,7 @@ static const struct i2c_device_id pca953x_id[] = {
{ "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
{ "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
{ "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
+ { "tca9554", 8 | PCA953X_TYPE | PCA_INT, },
{ "xra1202", 8 | PCA953X_TYPE },
{ }
};
diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
index 895af42a4513..8ddf9302ce3b 100644
--- a/drivers/gpio/gpio-pcf857x.c
+++ b/drivers/gpio/gpio-pcf857x.c
@@ -46,7 +46,6 @@ static const struct i2c_device_id pcf857x_id[] = {
{ "pca9675", 16 },
{ "max7328", 8 },
{ "max7329", 8 },
- { "tca9554", 8 },
{ }
};
MODULE_DEVICE_TABLE(i2c, pcf857x_id);
@@ -66,7 +65,6 @@ static const struct of_device_id pcf857x_of_table[] = {
{ .compatible = "nxp,pca9675" },
{ .compatible = "maxim,max7328" },
{ .compatible = "maxim,max7329" },
- { .compatible = "ti,tca9554" },
{ }
};
MODULE_DEVICE_TABLE(of, pcf857x_of_table);
--
2.11.0
[toc] | [next] | [standalone]
| From | Anders Darander <anders@chargestorm.se> |
|---|---|
| Date | 2017-04-21 14:50 +0200 |
| Subject | [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x |
| Message-ID | <tyGaC-5Ri-29@gated-at.bofh.it> |
| In reply to | #1628211 |
The TCA9554 is similar to the PCA9554. Update the DT binding docs.
Signed-off-by: Anders Darander <anders@chargestorm.se>
---
Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
index e63935710011..7f57271df2bc 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -26,6 +26,7 @@ Required properties:
ti,tca6416
ti,tca6424
ti,tca9539
+ ti,tca9554
onsemi,pca9654
exar,xra1202
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
index ada4e2973323..7d3bd631d011 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
@@ -25,7 +25,6 @@ Required Properties:
- "nxp,pcf8574": For the NXP PCF8574
- "nxp,pcf8574a": For the NXP PCF8574A
- "nxp,pcf8575": For the NXP PCF8575
- - "ti,tca9554": For the TI TCA9554
- reg: I2C slave address.
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-04-24 18:40 +0200 |
| Subject | Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x |
| Message-ID | <tzPbQ-Ue-15@gated-at.bofh.it> |
| In reply to | #1628218 |
On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote: > The TCA9554 is similar to the PCA9554. Update the DT binding docs. > > Signed-off-by: Anders Darander <anders@chargestorm.se> Patch applied. Seems like this component was misqualified at some point, let's repair it. yours, Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-04-26 10:00 +0200 |
| Subject | Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x |
| Message-ID | <tAq1I-7Hw-9@gated-at.bofh.it> |
| In reply to | #1628218 |
On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote:
> The TCA9554 is similar to the PCA9554. Update the DT binding docs.
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
> Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> index e63935710011..7f57271df2bc 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> @@ -26,6 +26,7 @@ Required properties:
> ti,tca6416
> ti,tca6424
> ti,tca9539
> + ti,tca9554
> onsemi,pca9654
> exar,xra1202
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> index ada4e2973323..7d3bd631d011 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> @@ -25,7 +25,6 @@ Required Properties:
> - "nxp,pcf8574": For the NXP PCF8574
> - "nxp,pcf8574a": For the NXP PCF8574A
> - "nxp,pcf8575": For the NXP PCF8575
> - - "ti,tca9554": For the TI TCA9554
>
> - reg: I2C slave address.
BTW, gpio-pca953x.txt seems to lack lots of gpio-controller-related properties.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-04-24 18:30 +0200 |
| Message-ID | <tzP2a-Rd-19@gated-at.bofh.it> |
| In reply to | #1628211 |
On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote: > The TCA9554 doesn't work with the pcf857x driver, trying to change the direction > gives a NAK bailout error. > > TCA9554 is similar to the PCA9554, thus change the driver. > > Signed-off-by: Anders Darander <anders@chargestorm.se> Patch applied. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web