Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628208 > unrolled thread
| Started by | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| First post | 2017-04-21 14:40 +0200 |
| Last post | 2017-04-27 07:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ Sekhar Nori <nsekhar@ti.com> - 2017-04-21 14:40 +0200
Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ Randy Dunlap <rdunlap@infradead.org> - 2017-04-23 04:30 +0200
Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ Sekhar Nori <nsekhar@ti.com> - 2017-04-24 13:50 +0200
Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ Randy Dunlap <rdunlap@infradead.org> - 2017-04-24 17:40 +0200
Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ Jonathan Cameron <jic23@kernel.org> - 2017-04-27 07:40 +0200
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-04-21 14:40 +0200 |
| Subject | [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__ |
| Message-ID | <tyG0W-5O5-27@gated-at.bofh.it> |
Use the local uapi headers to keep in sync with "recently" added enum values like IIO_UVINDEX. Build tested using: $ make -C <kernelsrcdir> tools/iio $ make -C <kernelsrcdir>/tools iio $ make -C <kernelsrcdir>/tools/iio This follows a strategy similar to that used by tools/hv, tools/net and tools/leds among others. Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Jonathan Cameron <jic23@kernel.org> Signed-off-by: Sekhar Nori <nsekhar@ti.com> --- Change since v1: Shift to a strategy similar to that used by other makefiles in tools/ folder. v1 posting here: https://patchwork.kernel.org/patch/9674937/ tools/iio/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/iio/Makefile b/tools/iio/Makefile index 5446d625e17d..8f08e03a9a5e 100644 --- a/tools/iio/Makefile +++ b/tools/iio/Makefile @@ -1,5 +1,5 @@ CC = $(CROSS_COMPILE)gcc -CFLAGS += -Wall -g -D_GNU_SOURCE +CFLAGS += -Wall -g -D_GNU_SOURCE -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include BINDIR=usr/bin INSTALL_PROGRAM=install -m 755 -p -- 2.9.0
[toc] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-04-23 04:30 +0200 |
| Message-ID | <tzfrH-2sC-1@gated-at.bofh.it> |
| In reply to | #1628208 |
On 04/21/17 05:31, Sekhar Nori wrote: > Use the local uapi headers to keep in sync with "recently" added enum > values like IIO_UVINDEX. > > Build tested using: > $ make -C <kernelsrcdir> tools/iio > $ make -C <kernelsrcdir>/tools iio > $ make -C <kernelsrcdir>/tools/iio Hi, Did you do any testing with O=<outputdir> ? Thanks. > This follows a strategy similar to that used by tools/hv, tools/net and > tools/leds among others. > > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: Jonathan Cameron <jic23@kernel.org> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > --- > Change since v1: > Shift to a strategy similar to that used by other makefiles in > tools/ folder. v1 posting here: https://patchwork.kernel.org/patch/9674937/ > > tools/iio/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/iio/Makefile b/tools/iio/Makefile > index 5446d625e17d..8f08e03a9a5e 100644 > --- a/tools/iio/Makefile > +++ b/tools/iio/Makefile > @@ -1,5 +1,5 @@ > CC = $(CROSS_COMPILE)gcc > -CFLAGS += -Wall -g -D_GNU_SOURCE > +CFLAGS += -Wall -g -D_GNU_SOURCE -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include > > BINDIR=usr/bin > INSTALL_PROGRAM=install -m 755 -p > -- ~Randy
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-04-24 13:50 +0200 |
| Message-ID | <tzKFc-6uK-3@gated-at.bofh.it> |
| In reply to | #1628898 |
Hi Randy, On Sunday 23 April 2017 07:52 AM, Randy Dunlap wrote: > On 04/21/17 05:31, Sekhar Nori wrote: >> Use the local uapi headers to keep in sync with "recently" added enum >> values like IIO_UVINDEX. >> >> Build tested using: >> $ make -C <kernelsrcdir> tools/iio >> $ make -C <kernelsrcdir>/tools iio >> $ make -C <kernelsrcdir>/tools/iio > > Hi, > Did you do any testing with O=<outputdir> ? I hadn't, but I just checked with: $ make -C <kernelsrcdir>/tools iio O=<outputdir> Although there is an iio folder created under <outputdir>, the actual binaries are still built under <kernelsrcdir>/tools/iio. So I think there is some more work to be done to respect the O= option passed from command line. The behavior remains same with or without my patch. Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-04-24 17:40 +0200 |
| Message-ID | <tzOfL-hH-1@gated-at.bofh.it> |
| In reply to | #1629445 |
On 04/24/17 04:40, Sekhar Nori wrote: > Hi Randy, > > On Sunday 23 April 2017 07:52 AM, Randy Dunlap wrote: >> On 04/21/17 05:31, Sekhar Nori wrote: >>> Use the local uapi headers to keep in sync with "recently" added enum >>> values like IIO_UVINDEX. >>> >>> Build tested using: >>> $ make -C <kernelsrcdir> tools/iio >>> $ make -C <kernelsrcdir>/tools iio >>> $ make -C <kernelsrcdir>/tools/iio >> >> Hi, >> Did you do any testing with O=<outputdir> ? > > I hadn't, but I just checked with: > > $ make -C <kernelsrcdir>/tools iio O=<outputdir> > > Although there is an iio folder created under <outputdir>, the actual > binaries are still built under <kernelsrcdir>/tools/iio. So I think > there is some more work to be done to respect the O= option passed from > command line. > > The behavior remains same with or without my patch. Yes, agreed. This is a common problem in tools. Thanks. -- ~Randy
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-04-27 07:40 +0200 |
| Message-ID | <tAKjL-4vc-3@gated-at.bofh.it> |
| In reply to | #1628208 |
On 21/04/17 13:31, Sekhar Nori wrote: > Use the local uapi headers to keep in sync with "recently" added enum > values like IIO_UVINDEX. > > Build tested using: > $ make -C <kernelsrcdir> tools/iio > $ make -C <kernelsrcdir>/tools iio > $ make -C <kernelsrcdir>/tools/iio > > This follows a strategy similar to that used by tools/hv, tools/net and > tools/leds among others. > > Cc: Randy Dunlap <rdunlap@infradead.org> > Cc: Jonathan Cameron <jic23@kernel.org> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to ignore it. Jonathan > --- > Change since v1: > Shift to a strategy similar to that used by other makefiles in > tools/ folder. v1 posting here: https://patchwork.kernel.org/patch/9674937/ > > tools/iio/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/iio/Makefile b/tools/iio/Makefile > index 5446d625e17d..8f08e03a9a5e 100644 > --- a/tools/iio/Makefile > +++ b/tools/iio/Makefile > @@ -1,5 +1,5 @@ > CC = $(CROSS_COMPILE)gcc > -CFLAGS += -Wall -g -D_GNU_SOURCE > +CFLAGS += -Wall -g -D_GNU_SOURCE -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include > > BINDIR=usr/bin > INSTALL_PROGRAM=install -m 755 -p >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web