Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1629214 > unrolled thread

linux-next: manual merge of the nvdimm tree with the block tree

Back to article view | Back to linux.kernel

Contents

  linux-next: manual merge of the nvdimm tree with the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-24 07:50 +0200

#1629214 — linux-next: manual merge of the nvdimm tree with the block tree

Hi Dan,

Today's linux-next merge of the nvdimm tree got a conflict in:

  drivers/block/brd.c

between commit:

  f09a06a193d9 ("brd: remove discard support")

from the block tree and commit:

  1647b9b959c7 ("brd: add dax_operations support")

from the nvdimm tree.

Dan, thanks for the example merge, but I am not sure you did it quite
right. I removed the first three '-' lines below, you did not.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/block/brd.c
index 4ec84d504780,bfa4ed2c75ef..000000000000
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@@ -415,9 -478,11 +429,6 @@@ static struct brd_device *brd_alloc(in
  	 *  is harmless)
  	 */
  	blk_queue_physical_block_size(brd->brd_queue, PAGE_SIZE);
- #ifdef CONFIG_BLK_DEV_RAM_DAX
- 	queue_flag_set_unlocked(QUEUE_FLAG_DAX, brd->brd_queue);
- #endif
 -
 -	brd->brd_queue->limits.discard_granularity = PAGE_SIZE;
 -	blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX);
 -	brd->brd_queue->limits.discard_zeroes_data = 1;
 -	queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, brd->brd_queue);
  	disk = brd->brd_disk = alloc_disk(max_part);
  	if (!disk)
  		goto out_free_queue;

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web