Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625111 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2017-04-18 10:00 +0200 |
| Last post | 2017-04-18 10:00 +0200 |
| Articles | 7 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] ARM: sun8i: a83t: device tree cleanup Chen-Yu Tsai <wens@csie.org> - 2017-04-18 10:00 +0200
[PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Chen-Yu Tsai <wens@csie.org> - 2017-04-18 10:00 +0200
Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-18 11:10 +0200
Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Chen-Yu Tsai <wens@csie.org> - 2017-04-18 11:20 +0200
Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-19 09:00 +0200
Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Chen-Yu Tsai <wens@csie.org> - 2017-04-21 05:40 +0200
[PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi Chen-Yu Tsai <wens@csie.org> - 2017-04-18 10:00 +0200
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-04-18 10:00 +0200 |
| Subject | [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup |
| Message-ID | <txwdj-3uy-3@gated-at.bofh.it> |
Hi Maxime, Here are a few patches cleaning up sun8i-a83t.dtsi. These get rid of known warnings and deprecated features. I'm sending these now before I send patches that add new stuff. Regards ChenYu Chen-Yu Tsai (3): ARM: sun8i: a83t: Drop skeleton.dtsi ARM: sun8i: a83t: Drop leading zeroes from device node addresses ARM: sun8i: a83t: Rename pinmux setting names .../boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 36 ++++++++++++++-------- 3 files changed, 25 insertions(+), 15 deletions(-) -- 2.11.0
[toc] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-04-18 10:00 +0200 |
| Subject | [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names |
| Message-ID | <txwdk-3uy-9@gated-at.bofh.it> |
| In reply to | #1625111 |
The pinmux setting nodes all have an address element in their node
names, however the pinctrl node does not have #address-cells.
Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi,
dropping identifiers for functions that only have one possible setting,
and using the pingroup name if the function is identically available on
different pingroups.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +-
arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +-
arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts
index 342e1d33fa1c..aecdeeb368ed 100644
--- a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts
@@ -59,6 +59,6 @@
&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_b>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};
diff --git a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
index 88b1e0970b8d..d2614f101ecc 100644
--- a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
@@ -60,6 +60,6 @@
&uart0 {
pinctrl-names = "default";
- pinctrl-0 = <&uart0_pins_b>;
+ pinctrl-0 = <&uart0_pb_pins>;
status = "okay";
};
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 82cb87f21b96..87b99338716b 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -174,7 +174,7 @@
#interrupt-cells = <3>;
#gpio-cells = <3>;
- mmc0_pins_a: mmc0@0 {
+ mmc0_pins: mmc0_pins {
pins = "PF0", "PF1", "PF2",
"PF3", "PF4", "PF5";
function = "mmc0";
@@ -182,13 +182,13 @@
bias-pull-up;
};
- uart0_pins_a: uart0@0 {
- pins = "PF2", "PF4";
+ uart0_pb_pins: uart0_pb_pins {
+ pins = "PB9", "PB10";
function = "uart0";
};
- uart0_pins_b: uart0@1 {
- pins = "PB9", "PB10";
+ uart0_pf_pins: uart0_pf_pins {
+ pins = "PF2", "PF4";
function = "uart0";
};
};
--
2.11.0
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-04-18 11:10 +0200 |
| Subject | Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names |
| Message-ID | <txxj5-4lo-41@gated-at.bofh.it> |
| In reply to | #1625112 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied, and I really like the new names. Would you make the same patch for everyone? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-04-18 11:20 +0200 |
| Subject | Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names |
| Message-ID | <txxsJ-4oB-1@gated-at.bofh.it> |
| In reply to | #1625168 |
On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: >> The pinmux setting nodes all have an address element in their node >> names, however the pinctrl node does not have #address-cells. >> >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, >> dropping identifiers for functions that only have one possible setting, >> and using the pingroup name if the function is identically available on >> different pingroups. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Applied, and I really like the new names. > > Would you make the same patch for everyone? I can. No guarantees on the schedule though. ChenYu
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-04-19 09:00 +0200 |
| Subject | Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names |
| Message-ID | <txRKO-8uq-7@gated-at.bofh.it> |
| In reply to | #1625170 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Apr 18, 2017 at 05:16:53PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > >> The pinmux setting nodes all have an address element in their node > >> names, however the pinctrl node does not have #address-cells. > >> > >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > >> dropping identifiers for functions that only have one possible setting, > >> and using the pingroup name if the function is identically available on > >> different pingroups. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > Applied, and I really like the new names. > > > > Would you make the same patch for everyone? > > I can. No guarantees on the schedule though. Sure, I know this isn't really the most entertaining and fulfilling patch to make ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-04-21 05:40 +0200 |
| Subject | Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names |
| Message-ID | <tyxAm-Ku-15@gated-at.bofh.it> |
| In reply to | #1625112 |
On Tue, Apr 18, 2017 at 12:22 PM, Chen-Yu Tsai <wens@csie.org> wrote:
> The pinmux setting nodes all have an address element in their node
> names, however the pinctrl node does not have #address-cells.
>
> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi,
> dropping identifiers for functions that only have one possible setting,
> and using the pingroup name if the function is identically available on
> different pingroups.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +-
> arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +-
> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
[...]
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 82cb87f21b96..87b99338716b 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -174,7 +174,7 @@
> #interrupt-cells = <3>;
> #gpio-cells = <3>;
>
> - mmc0_pins_a: mmc0@0 {
> + mmc0_pins: mmc0_pins {
> pins = "PF0", "PF1", "PF2",
> "PF3", "PF4", "PF5";
> function = "mmc0";
> @@ -182,13 +182,13 @@
> bias-pull-up;
> };
>
> - uart0_pins_a: uart0@0 {
> - pins = "PF2", "PF4";
> + uart0_pb_pins: uart0_pb_pins {
Duh... Forgot to use hyphens instead of underscores in the node names.
I'll send a patch for you to squash in.
ChenYu
> + pins = "PB9", "PB10";
> function = "uart0";
> };
>
> - uart0_pins_b: uart0@1 {
> - pins = "PB9", "PB10";
> + uart0_pf_pins: uart0_pf_pins {
> + pins = "PF2", "PF4";
> function = "uart0";
> };
> };
> --
> 2.11.0
>
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-04-18 10:00 +0200 |
| Subject | [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi |
| Message-ID | <txwdk-3uy-13@gated-at.bofh.it> |
| In reply to | #1625111 |
skeleton.dtsi is deprecated. Remove it from sun8i-a83t.dtsi and add
the needed device nodes directly.
Also drop an extra, non-style-conforming line in the copyright license
header.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 0ec143773ee9..913aacafe8d5 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -40,15 +40,20 @@
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
-
*/
-#include "skeleton.dtsi"
-
#include <dt-bindings/interrupt-controller/arm-gic.h>
/ {
interrupt-parent = <&gic>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ aliases {
+ };
+
+ chosen {
+ };
cpus {
#address-cells = <1>;
@@ -146,6 +151,11 @@
};
};
+ memory {
+ reg = <0x40000000 0x80000000>;
+ device_type = "memory";
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <1>;
--
2.11.0
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web