Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627906 > unrolled thread

linux-next: build failure after merge of the rdma tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-04-21 03:50 +0200
Last post2017-04-21 04:30 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the rdma tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-21 03:50 +0200
    Re: linux-next: build failure after merge of the rdma tree Joe Perches <joe@perches.com> - 2017-04-21 04:10 +0200
      Re: linux-next: build failure after merge of the rdma tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-21 04:30 +0200
      Re: linux-next: build failure after merge of the rdma tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-21 04:30 +0200
      Re: linux-next: build failure after merge of the rdma tree Doug Ledford <dledford@redhat.com> - 2017-04-21 04:30 +0200

#1627906 — linux-next: build failure after merge of the rdma tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-04-21 03:50 +0200
Subjectlinux-next: build failure after merge of the rdma tree
Message-ID<tyvRT-81l-3@gated-at.bofh.it>
Hi Doug,

After merging the rdma tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration of function 'PDBG' [-Werror=implicit-function-declaration]
     PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
     ^

Caused by commit

  a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")

I have used the rdma tree from next-20170420 for today.

There was another PDBG() missed in that file as well.
-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1627915

FromJoe Perches <joe@perches.com>
Date2017-04-21 04:10 +0200
Message-ID<tywbg-8mP-11@gated-at.bofh.it>
In reply to#1627906
On Fri, 2017-04-21 at 11:42 +1000, Stephen Rothwell wrote:
> Hi Doug,
> 
> After merging the rdma tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
> drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration of function 'PDBG' [-Werror=implicit-function-declaration]
>      PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
>      ^
> 
> Caused by commit
> 
>   a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")
> 
> I have used the rdma tree from next-20170420 for today.
> 
> There was another PDBG() missed in that file as well.

Pretty sure there were crossing commits adding PDBG()
as the original patches were written against next-20170209

From my tree:

$ git log --pretty=oneline -5 747edc68212781296de30dd2b4e63711240da7a9
747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to pr_debug
d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common logging style
41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to pr_debug
15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common logging style
9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific files for 20170209

$ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
$

[toc] | [prev] | [next] | [standalone]

#1627922

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-04-21 04:30 +0200
Message-ID<tywuB-7t-1@gated-at.bofh.it>
In reply to#1627915
Hi Joe,

On Thu, 20 Apr 2017 18:58:55 -0700 Joe Perches <joe@perches.com> wrote:
>
> Pretty sure there were crossing commits adding PDBG()
> as the original patches were written against next-20170209
> 
> From my tree:
> 
> $ git log --pretty=oneline -5 747edc68212781296de30dd2b4e63711240da7a9
> 747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to pr_debug
> d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common logging style
> 41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to pr_debug
> 15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common logging style
> 9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific files for 20170209
> 
> $ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
> $

In the rdma tree:

$ git log --pretty=oneline -5 a9a42886d0b3
a9a42886d0b3b989166472b7ea59b1c157d90f9b cxgb4: Convert PDBG to pr_debug
700456bd25946ef531773d1ad2dd511e1cc4515e cxgb4: Use more common logging style
b7b37ee0e137c8384c6cb3a37c4621649d5acdf6 cxgb3: Convert PDBG to pr_debug
46b2d4e8eca752003b903e68c3bec6b15fd7eba0 cxgb3: Use more common logging style
cd565b4b51e5fe258d6ce9ddc167ee51f3044ba5 IB/IPoIB: Support acceleration options callbacks
$ git grep -w PDBG a9a42886d0b3
a9a42886d0b3:drivers/infiniband/hw/cxgb4/cm.c:                          PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
a9a42886d0b3:drivers/infiniband/hw/cxgb4/cm.c:                          PDBG("%s snd_isn %u\n", __func__, t6req6->rsvd);

So these were added somewhere in Doug's tree and they need to be fixed
up there.  Your patches were rebased/cherrypicked/applied on to Doug's tree.

Ah, the new ones come from commit

  192539f4ce36 "iw_cxgb4: clean up send_connect()"

but that is in v4.11-rc1 and so should would not have been in next-20170209.
-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1627925

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-04-21 04:30 +0200
Message-ID<tywuC-7t-11@gated-at.bofh.it>
In reply to#1627915
Hi Doug,

On Thu, 20 Apr 2017 22:21:15 -0400 Doug Ledford <dledford@redhat.com> wrote:
>
> I created a fix and added it to my tree.

Thanks.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1627928

FromDoug Ledford <dledford@redhat.com>
Date2017-04-21 04:30 +0200
Message-ID<tywuC-7t-13@gated-at.bofh.it>
In reply to#1627915
On Thu, 2017-04-20 at 18:58 -0700, Joe Perches wrote:
> On Fri, 2017-04-21 at 11:42 +1000, Stephen Rothwell wrote:
> > 
> > Hi Doug,
> > 
> > After merging the rdma tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/infiniband/hw/cxgb4/cm.c: In function 'send_connect':
> > drivers/infiniband/hw/cxgb4/cm.c:830:5: error: implicit declaration
> > of function 'PDBG' [-Werror=implicit-function-declaration]
> >      PDBG("%s snd_isn %u\n", __func__, t6req->rsvd);
> >      ^
> > 
> > Caused by commit
> > 
> >   a9a42886d0b3 ("cxgb4: Convert PDBG to pr_debug")
> > 
> > I have used the rdma tree from next-20170420 for today.
> > 
> > There was another PDBG() missed in that file as well.
> 
> Pretty sure there were crossing commits adding PDBG()
> as the original patches were written against next-20170209
> 
> From my tree:
> 
> $ git log --pretty=oneline -5
> 747edc68212781296de30dd2b4e63711240da7a9
> 747edc68212781296de30dd2b4e63711240da7a9 cxgb4: Convert PDBG to
> pr_debug
> d054cd530aeef452c7c252504f7d4d6ebba31ae3 cxgb4: Use more common
> logging style
> 41a74ceecd35cf2f38e2a1a1a394c7718547deb6 cxgb3: Convert PDBG to
> pr_debug
> 15772862930dfd2f2e10574b86c063d781976a89 cxgb3: Use more common
> logging style
> 9f7e70ff42dbf3af7ed0699906b699c41930b265 Add linux-next specific
> files for 20170209
> 
> $ git grep -w PDBG 747edc68212781296de30dd2b4e63711240da7a9
> $

I created a fix and added it to my tree.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web