Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1627892 > unrolled thread
| Started by | Stefan Agner <stefan@agner.ch> |
|---|---|
| First post | 2017-04-21 03:10 +0200 |
| Last post | 2017-04-21 04:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Stefan Agner <stefan@agner.ch> - 2017-04-21 03:10 +0200
[PATCH 3/5] mtd: gpmi: document current clock requirements Stefan Agner <stefan@agner.ch> - 2017-04-21 03:10 +0200
Re: [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support Marek Vasut <marek.vasut@gmail.com> - 2017-04-21 04:40 +0200
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2017-04-21 03:10 +0200 |
| Subject | [PATCH 0/5] mtd: nand: gpmi: add i.MX 7 support |
| Message-ID | <tyvfb-7P1-3@gated-at.bofh.it> |
This patchset adds support for i.MX 7 SoC for the GPMI NAND controller. There have been similar patchsets already: https://lkml.org/lkml/2016/2/23/912 However, this patchset does not make use of any of the new features. The current feature set seems to work fine, I successfully run the MTD tests on a Colibri iMX7. -- Stefan Stefan Agner (5): mtd: nand: gpmi: unify clock handling mtd: nand: gpmi: add i.MX 7 SoC support mtd: gpmi: document current clock requirements ARM: dts: imx7: add GPMI NAND ARM: dts: imx7-colibri: add NAND support .../devicetree/bindings/mtd/gpmi-nand.txt | 14 +++++- arch/arm/boot/dts/imx7-colibri.dtsi | 9 ++++ arch/arm/boot/dts/imx7s.dtsi | 31 ++++++++++++ drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 56 +++++++++++++--------- drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 2 + 5 files changed, 88 insertions(+), 24 deletions(-) -- 2.12.2
[toc] | [next] | [standalone]
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2017-04-21 03:10 +0200 |
| Subject | [PATCH 3/5] mtd: gpmi: document current clock requirements |
| Message-ID | <tyvfc-7P1-11@gated-at.bofh.it> |
| In reply to | #1627892 |
The clock requirements are completely missing, add the clocks
currently required by the driver.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
index d02acaff3c35..b289ef3c1b7e 100644
--- a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
+++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
@@ -4,7 +4,12 @@ The GPMI nand controller provides an interface to control the
NAND flash chips.
Required properties:
- - compatible : should be "fsl,<chip>-gpmi-nand"
+ - compatible : should be "fsl,<chip>-gpmi-nand", chip can be:
+ * imx23
+ * imx28
+ * imx6q
+ * imx6sx
+ * imx7d
- reg : should contain registers location and length for gpmi and bch.
- reg-names: Should contain the reg names "gpmi-nand" and "bch"
- interrupts : BCH interrupt number.
@@ -13,6 +18,13 @@ Required properties:
and GPMI DMA channel ID.
Refer to dma.txt and fsl-mxs-dma.txt for details.
- dma-names: Must be "rx-tx".
+ - clocks : clocks phandle and clock specifier corresponding to each clock
+ specified in clock-names.
+ - clock-names : The "gpmi_io" clock is always required. Which clocks are
+ exactly required depends on chip:
+ * imx23/imx28 : "gpmi_io"
+ * imx6q/sx : "gpmi_io", "gpmi_apb", "gpmi_bch", "gpmi_bch_apb", "per1_bch"
+ * imx7d : "gpmi_io", "gpmi_bch_apb"
Optional properties:
- nand-on-flash-bbt: boolean to enable on flash bbt option if not
--
2.12.2
[toc] | [prev] | [next] | [standalone]
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Date | 2017-04-21 04:40 +0200 |
| Message-ID | <tywEh-az-7@gated-at.bofh.it> |
| In reply to | #1627892 |
On 04/21/2017 03:07 AM, Stefan Agner wrote: > This patchset adds support for i.MX 7 SoC for the GPMI NAND controller. > There have been similar patchsets already: > https://lkml.org/lkml/2016/2/23/912 > > However, this patchset does not make use of any of the new features. > The current feature set seems to work fine, I successfully run the MTD > tests on a Colibri iMX7. > > -- The rest of the patchset is IMO OK too, but you probably want the DT changes Acked by Shawn or Fabio. -- Best regards, Marek Vasut
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web