Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627742 > unrolled thread

[PATCH v2] timer/sysclt: Restrict timer migration sysctl values to 0 and 1

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] timer/sysclt: Restrict timer migration sysctl values to 0 and 1 Myungho Jung <mhjungk@gmail.com> - 2017-04-20 20:50 +0200
    Re: [PATCH v2] timer/sysclt: Restrict timer migration sysctl values  to 0 and 1 Thomas Gleixner <tglx@linutronix.de> - 2017-04-20 21:50 +0200

#1627742 — [PATCH v2] timer/sysclt: Restrict timer migration sysctl values to 0 and 1

timer_migration sysctl acts as a boolean switch, so the allowed values
should be restricted to 0 and 1.

Add the necessary extra fields to the sysctl table entry to enforce
that.

Testcase is ltp/runpwtests06.

Signed-off-by: Myungho Jung <mhjungk@gmail.com>
---
Changes in v2:
 - Correct commit log

 kernel/sysctl.c     | 2 ++
 kernel/time/timer.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 8c8714f..21343d1 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1176,6 +1176,8 @@ static struct ctl_table kern_table[] = {
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
 		.proc_handler	= timer_migration_handler,
+		.extra1		= &zero,
+		.extra2		= &one,
 	},
 #endif
 #ifdef CONFIG_BPF_SYSCALL
diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 1dc0256..cc6b6bd 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -241,7 +241,7 @@ int timer_migration_handler(struct ctl_table *table, int write,
 	int ret;
 
 	mutex_lock(&mutex);
-	ret = proc_dointvec(table, write, buffer, lenp, ppos);
+	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
 	if (!ret && write)
 		timers_update_migration(false);
 	mutex_unlock(&mutex);
-- 
2.7.4

[toc] | [next] | [standalone]

#1627765 — Re: [PATCH v2] timer/sysclt: Restrict timer migration sysctl values to 0 and 1

On Thu, 20 Apr 2017, Myungho Jung wrote:

I told you to check your mail so you avoid sending a V2. That mail from
tip-bot is a notification that:

This 
> Commit-ID:  b94bf594cf8ed67cdd0439e70fa939783471597a

which can be looked at via:
> Gitweb:     http://git.kernel.org/tip/b94bf594cf8ed67cdd0439e70fa939783471597a

authored by:
> Author:     Myungho Jung <mhjungk@gmail.com>

on:
> AuthorDate: Wed, 19 Apr 2017 15:24:50 -0700

was commited by:
> Committer:  Thomas Gleixner <tglx@linutronix.de>

on:
> CommitDate: Thu, 20 Apr 2017 14:56:59 +0200

And the subject line of that mail tells you the branch inside the tip
repository and the subject line of the commit:

> [tip:timers/core] timer/sysclt: Restrict timer migration sysctl values to 0 and 1

Thanks,

	tglx

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web