Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1627171 > unrolled thread

RE: [PATCH 0/2] fs, ceph filesystem refcount conversions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH 0/2] fs, ceph filesystem refcount conversions "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-20 09:50 +0200
    Re: [PATCH 0/2] fs, ceph filesystem refcount conversions Ilya Dryomov <idryomov@gmail.com> - 2017-04-20 11:50 +0200
      RE: [PATCH 0/2] fs, ceph filesystem refcount conversions "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-20 12:30 +0200

#1627171 — RE: [PATCH 0/2] fs, ceph filesystem refcount conversions

> On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova
> <elena.reshetova@intel.com> wrote:
> > Now when new refcount_t type and API are finally merged
> > (see include/linux/refcount.h), the following
> > patches convert various refcounters in the ceph filesystem from atomic_t
> > to refcount_t. By doing this we prevent intentional or accidental
> > underflows or overflows that can led to use-after-free vulnerabilities.
> >
> > The below patches are fully independent and can be cherry-picked separately.
> > Since we convert all kernel subsystems in the same fashion, resulting
> > in about 300 patches, we have to group them for sending at least in some
> > fashion to be manageable. Please excuse the long cc list.
> >
> > Not runtime tested, since I am not sure how to do it for ceph.
> > However changes are pretty trivial in this case.
> >
> > Elena Reshetova (2):
> >   fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
> >   fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t
> >
> >  fs/ceph/caps.c       |  4 ++--
> >  fs/ceph/mds_client.c | 18 +++++++++---------
> >  fs/ceph/mds_client.h |  5 +++--
> >  fs/ceph/snap.c       |  2 +-
> >  fs/ceph/super.h      |  5 +++--
> >  5 files changed, 18 insertions(+), 16 deletions(-)
> 
> I'll pull these into testing.

Just a check: how did testing went on this? 
If everything is good, can you merge the changes?

Best Regards,
Elena.

> 
> Thanks,
> 
>                 Ilya

[toc] | [next] | [standalone]

#1627245

On Thu, Apr 20, 2017 at 9:40 AM, Reshetova, Elena
<elena.reshetova@intel.com> wrote:
>
>> On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova
>> <elena.reshetova@intel.com> wrote:
>> > Now when new refcount_t type and API are finally merged
>> > (see include/linux/refcount.h), the following
>> > patches convert various refcounters in the ceph filesystem from atomic_t
>> > to refcount_t. By doing this we prevent intentional or accidental
>> > underflows or overflows that can led to use-after-free vulnerabilities.
>> >
>> > The below patches are fully independent and can be cherry-picked separately.
>> > Since we convert all kernel subsystems in the same fashion, resulting
>> > in about 300 patches, we have to group them for sending at least in some
>> > fashion to be manageable. Please excuse the long cc list.
>> >
>> > Not runtime tested, since I am not sure how to do it for ceph.
>> > However changes are pretty trivial in this case.
>> >
>> > Elena Reshetova (2):
>> >   fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
>> >   fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t
>> >
>> >  fs/ceph/caps.c       |  4 ++--
>> >  fs/ceph/mds_client.c | 18 +++++++++---------
>> >  fs/ceph/mds_client.h |  5 +++--
>> >  fs/ceph/snap.c       |  2 +-
>> >  fs/ceph/super.h      |  5 +++--
>> >  5 files changed, 18 insertions(+), 16 deletions(-)
>>
>> I'll pull these into testing.
>
> Just a check: how did testing went on this?
> If everything is good, can you merge the changes?

Yep, I'll merge these into 4.12.

Thanks,

                Ilya

[toc] | [prev] | [next] | [standalone]

#1627296

> On Thu, Apr 20, 2017 at 9:40 AM, Reshetova, Elena
> <elena.reshetova@intel.com> wrote:
> >
> >> On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova
> >> <elena.reshetova@intel.com> wrote:
> >> > Now when new refcount_t type and API are finally merged
> >> > (see include/linux/refcount.h), the following
> >> > patches convert various refcounters in the ceph filesystem from atomic_t
> >> > to refcount_t. By doing this we prevent intentional or accidental
> >> > underflows or overflows that can led to use-after-free vulnerabilities.
> >> >
> >> > The below patches are fully independent and can be cherry-picked
> separately.
> >> > Since we convert all kernel subsystems in the same fashion, resulting
> >> > in about 300 patches, we have to group them for sending at least in some
> >> > fashion to be manageable. Please excuse the long cc list.
> >> >
> >> > Not runtime tested, since I am not sure how to do it for ceph.
> >> > However changes are pretty trivial in this case.
> >> >
> >> > Elena Reshetova (2):
> >> >   fs, ceph: convert ceph_mds_session.s_ref from atomic_t to refcount_t
> >> >   fs, ceph: convert ceph_cap_snap.nref from atomic_t to refcount_t
> >> >
> >> >  fs/ceph/caps.c       |  4 ++--
> >> >  fs/ceph/mds_client.c | 18 +++++++++---------
> >> >  fs/ceph/mds_client.h |  5 +++--
> >> >  fs/ceph/snap.c       |  2 +-
> >> >  fs/ceph/super.h      |  5 +++--
> >> >  5 files changed, 18 insertions(+), 16 deletions(-)
> >>
> >> I'll pull these into testing.
> >
> > Just a check: how did testing went on this?
> > If everything is good, can you merge the changes?
> 
> Yep, I'll merge these into 4.12.

Great, thank you!

Best Regards,
Elena.
> 
> Thanks,
> 
>                 Ilya

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web