Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627113 > unrolled thread

[PATCH] nl80211: fix enumeration type

Started byStefan Agner <stefan@agner.ch>
First post2017-04-20 09:00 +0200
Last post2017-04-20 16:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] nl80211: fix enumeration type Stefan Agner <stefan@agner.ch> - 2017-04-20 09:00 +0200
    Re: [PATCH] nl80211: fix enumeration type Johannes Berg <johannes@sipsolutions.net> - 2017-04-20 09:30 +0200
      Re: [PATCH] nl80211: fix enumeration type Stefan Agner <stefan@agner.ch> - 2017-04-20 16:30 +0200

#1627113 — [PATCH] nl80211: fix enumeration type

FromStefan Agner <stefan@agner.ch>
Date2017-04-20 09:00 +0200
Subject[PATCH] nl80211: fix enumeration type
Message-ID<tyeen-5AX-33@gated-at.bofh.it>
Use type enum nl80211_rate_info for bitrate information. This fixes
a warning when compiling with clang:
  warning: implicit conversion from enumeration type 'enum nl80211_rate_info'
  to different enumeration type 'enum nl80211_attrs'

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 2312dc2ffdb9..9af21a21ea6b 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4151,7 +4151,7 @@ static bool nl80211_put_sta_rate(struct sk_buff *msg, struct rate_info *info,
 	struct nlattr *rate;
 	u32 bitrate;
 	u16 bitrate_compat;
-	enum nl80211_attrs rate_flg;
+	enum nl80211_rate_info rate_flg;
 
 	rate = nla_nest_start(msg, attr);
 	if (!rate)
-- 
2.12.2

[toc] | [next] | [standalone]


#1627162

FromJohannes Berg <johannes@sipsolutions.net>
Date2017-04-20 09:30 +0200
Message-ID<tyeHo-60B-5@gated-at.bofh.it>
In reply to#1627113
On Wed, 2017-04-19 at 23:55 -0700, Stefan Agner wrote:
> Use type enum nl80211_rate_info for bitrate information. This fixes
> a warning when compiling with clang:
>   warning: implicit conversion from enumeration type 'enum
> nl80211_rate_info'
>   to different enumeration type 'enum nl80211_attrs'

I'm pretty sure I just applied exactly these two patches very recently.

What made *two* people suddenly see this?

johannes

[toc] | [prev] | [next] | [standalone]


#1627530

FromStefan Agner <stefan@agner.ch>
Date2017-04-20 16:30 +0200
Message-ID<tylfP-1Ck-1@gated-at.bofh.it>
In reply to#1627162
On 2017-04-20 00:22, Johannes Berg wrote:
> On Wed, 2017-04-19 at 23:55 -0700, Stefan Agner wrote:
>> Use type enum nl80211_rate_info for bitrate information. This fixes
>> a warning when compiling with clang:
>>   warning: implicit conversion from enumeration type 'enum
>> nl80211_rate_info'
>>   to different enumeration type 'enum nl80211_attrs'
> 
> I'm pretty sure I just applied exactly these two patches very recently.
> 
> What made *two* people suddenly see this?

There has been renewed work on compiling Linux using clang... Sorry for
the clash.

--
Stefan

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web