Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626935 > unrolled thread

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2 "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-20 04:40 +0200

#1626935 — Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Dmitry Monakhov <dmonakhov@openvz.org> writes:

> bio_integrity_trim inherent it's interface from bio_trim and accept
> offset and size, but this API is error prone because data offset must
> always be insync with bio's data offset. That is why we have integrity
> update hook in bio_advance()
>
> So only meaningful values are: offset == 0, sectors ==
> bio_sectors(bio) Let's just remove them completely.

This interface predates the iter/immutable stuff. It should be fine to
remove the call arguments now.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web