Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626745 > unrolled thread

[PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup()

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-04-19 22:00 +0200
Last post2017-04-22 05:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 22:00 +0200
    Re: [PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup() Stephen Boyd <sboyd@codeaurora.org> - 2017-04-22 05:00 +0200

#1626745 — [PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-19 22:00 +0200
Subject[PATCH 1/5] clk: mvebu: Use kcalloc() in of_cpu_clk_setup()
Message-ID<ty3VD-7vf-1@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Apr 2017 20:15:21 +0200

Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/clk/mvebu/clk-cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 044892b6534d..072aa38374ce 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -186,11 +186,11 @@ static void __init of_cpu_clk_setup(struct device_node *node)
 	for_each_node_by_type(dn, "cpu")
 		ncpus++;
 
-	cpuclk = kzalloc(ncpus * sizeof(*cpuclk), GFP_KERNEL);
+	cpuclk = kcalloc(ncpus, sizeof(*cpuclk), GFP_KERNEL);
 	if (WARN_ON(!cpuclk))
 		goto cpuclk_out;
 
-	clks = kzalloc(ncpus * sizeof(*clks), GFP_KERNEL);
+	clks = kcalloc(ncpus, sizeof(*clks), GFP_KERNEL);
 	if (WARN_ON(!clks))
 		goto clks_out;
 
-- 
2.12.2

[toc] | [next] | [standalone]


#1628748

FromStephen Boyd <sboyd@codeaurora.org>
Date2017-04-22 05:00 +0200
Message-ID<tyTrc-5zp-3@gated-at.bofh.it>
In reply to#1626745
On 04/19, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 19 Apr 2017 20:15:21 +0200
> 
> Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
> Thus use the corresponding function "kcalloc".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web