Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1627887 > unrolled thread
| Started by | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| First post | 2017-04-21 03:00 +0200 |
| Last post | 2017-04-24 19:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] f2fs: add braces for macro variables more Jaegeuk Kim <jaegeuk@kernel.org> - 2017-04-21 03:00 +0200
Re: [PATCH 1/2] f2fs: add braces for macro variables more Chao Yu <yuchao0@huawei.com> - 2017-04-22 02:40 +0200
Re: [PATCH 1/2] f2fs: add braces for macro variables more Jaegeuk Kim <jaegeuk@kernel.org> - 2017-04-24 19:40 +0200
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-04-21 03:00 +0200 |
| Subject | [PATCH 1/2] f2fs: add braces for macro variables more |
| Message-ID | <tyv5w-7uf-11@gated-at.bofh.it> |
This patch adds braces for macro variables more in include/linux/f2fs_fs.h.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/f2fs.h | 1 +
include/linux/f2fs_fs.h | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index e2d9a8d9101e..ca647d264b61 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -16,6 +16,7 @@
#include <linux/buffer_head.h>
#include <linux/slab.h>
#include <linux/crc32.h>
+#include <linux/quota.h>
#include <linux/magic.h>
#include <linux/kobject.h>
#include <linux/sched.h>
diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
index e2d239ed4c60..639cbdf65e2b 100644
--- a/include/linux/f2fs_fs.h
+++ b/include/linux/f2fs_fs.h
@@ -32,9 +32,9 @@
/* 0, 1(node nid), 2(meta nid) are reserved node id */
#define F2FS_RESERVED_NODE_NUM 3
-#define F2FS_ROOT_INO(sbi) (sbi->root_ino_num)
-#define F2FS_NODE_INO(sbi) (sbi->node_ino_num)
-#define F2FS_META_INO(sbi) (sbi->meta_ino_num)
+#define F2FS_ROOT_INO(sbi) ((sbi)->root_ino_num)
+#define F2FS_NODE_INO(sbi) ((sbi)->node_ino_num)
+#define F2FS_META_INO(sbi) ((sbi)->meta_ino_num)
#define F2FS_IO_SIZE(sbi) (1 << (sbi)->write_io_size_bits) /* Blocks */
#define F2FS_IO_SIZE_KB(sbi) (1 << ((sbi)->write_io_size_bits + 2)) /* KB */
@@ -161,7 +161,7 @@ struct f2fs_checkpoint {
*/
#define F2FS_ORPHANS_PER_BLOCK 1020
-#define GET_ORPHAN_BLOCKS(n) ((n + F2FS_ORPHANS_PER_BLOCK - 1) / \
+#define GET_ORPHAN_BLOCKS(n) (((n) + F2FS_ORPHANS_PER_BLOCK - 1) / \
F2FS_ORPHANS_PER_BLOCK)
struct f2fs_orphan_block {
@@ -449,7 +449,7 @@ typedef __le32 f2fs_hash_t;
#define F2FS_SLOT_LEN 8
#define F2FS_SLOT_LEN_BITS 3
-#define GET_DENTRY_SLOTS(x) ((x + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
+#define GET_DENTRY_SLOTS(x) (((x) + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
/* MAX level for dir lookup */
#define MAX_DIR_HASH_DEPTH 63
--
2.11.0
[toc] | [next] | [standalone]
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-04-22 02:40 +0200 |
| Message-ID | <tyRfI-4bf-3@gated-at.bofh.it> |
| In reply to | #1627887 |
On 2017/4/21 8:49, Jaegeuk Kim wrote:
> This patch adds braces for macro variables more in include/linux/f2fs_fs.h.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/f2fs.h | 1 +
> include/linux/f2fs_fs.h | 10 +++++-----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index e2d9a8d9101e..ca647d264b61 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -16,6 +16,7 @@
> #include <linux/buffer_head.h>
> #include <linux/slab.h>
> #include <linux/crc32.h>
> +#include <linux/quota.h>
This is no needed. ;)
Thanks,
> #include <linux/magic.h>
> #include <linux/kobject.h>
> #include <linux/sched.h>
> diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
> index e2d239ed4c60..639cbdf65e2b 100644
> --- a/include/linux/f2fs_fs.h
> +++ b/include/linux/f2fs_fs.h
> @@ -32,9 +32,9 @@
> /* 0, 1(node nid), 2(meta nid) are reserved node id */
> #define F2FS_RESERVED_NODE_NUM 3
>
> -#define F2FS_ROOT_INO(sbi) (sbi->root_ino_num)
> -#define F2FS_NODE_INO(sbi) (sbi->node_ino_num)
> -#define F2FS_META_INO(sbi) (sbi->meta_ino_num)
> +#define F2FS_ROOT_INO(sbi) ((sbi)->root_ino_num)
> +#define F2FS_NODE_INO(sbi) ((sbi)->node_ino_num)
> +#define F2FS_META_INO(sbi) ((sbi)->meta_ino_num)
>
> #define F2FS_IO_SIZE(sbi) (1 << (sbi)->write_io_size_bits) /* Blocks */
> #define F2FS_IO_SIZE_KB(sbi) (1 << ((sbi)->write_io_size_bits + 2)) /* KB */
> @@ -161,7 +161,7 @@ struct f2fs_checkpoint {
> */
> #define F2FS_ORPHANS_PER_BLOCK 1020
>
> -#define GET_ORPHAN_BLOCKS(n) ((n + F2FS_ORPHANS_PER_BLOCK - 1) / \
> +#define GET_ORPHAN_BLOCKS(n) (((n) + F2FS_ORPHANS_PER_BLOCK - 1) / \
> F2FS_ORPHANS_PER_BLOCK)
>
> struct f2fs_orphan_block {
> @@ -449,7 +449,7 @@ typedef __le32 f2fs_hash_t;
> #define F2FS_SLOT_LEN 8
> #define F2FS_SLOT_LEN_BITS 3
>
> -#define GET_DENTRY_SLOTS(x) ((x + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
> +#define GET_DENTRY_SLOTS(x) (((x) + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
>
> /* MAX level for dir lookup */
> #define MAX_DIR_HASH_DEPTH 63
>
[toc] | [prev] | [next] | [standalone]
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-04-24 19:40 +0200 |
| Message-ID | <tzQ7U-1tV-19@gated-at.bofh.it> |
| In reply to | #1628707 |
On 04/22, Chao Yu wrote:
> On 2017/4/21 8:49, Jaegeuk Kim wrote:
> > This patch adds braces for macro variables more in include/linux/f2fs_fs.h.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/f2fs.h | 1 +
> > include/linux/f2fs_fs.h | 10 +++++-----
> > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index e2d9a8d9101e..ca647d264b61 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -16,6 +16,7 @@
> > #include <linux/buffer_head.h>
> > #include <linux/slab.h>
> > #include <linux/crc32.h>
> > +#include <linux/quota.h>
>
> This is no needed. ;)
Yup. :)
>
> Thanks,
>
> > #include <linux/magic.h>
> > #include <linux/kobject.h>
> > #include <linux/sched.h>
> > diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
> > index e2d239ed4c60..639cbdf65e2b 100644
> > --- a/include/linux/f2fs_fs.h
> > +++ b/include/linux/f2fs_fs.h
> > @@ -32,9 +32,9 @@
> > /* 0, 1(node nid), 2(meta nid) are reserved node id */
> > #define F2FS_RESERVED_NODE_NUM 3
> >
> > -#define F2FS_ROOT_INO(sbi) (sbi->root_ino_num)
> > -#define F2FS_NODE_INO(sbi) (sbi->node_ino_num)
> > -#define F2FS_META_INO(sbi) (sbi->meta_ino_num)
> > +#define F2FS_ROOT_INO(sbi) ((sbi)->root_ino_num)
> > +#define F2FS_NODE_INO(sbi) ((sbi)->node_ino_num)
> > +#define F2FS_META_INO(sbi) ((sbi)->meta_ino_num)
> >
> > #define F2FS_IO_SIZE(sbi) (1 << (sbi)->write_io_size_bits) /* Blocks */
> > #define F2FS_IO_SIZE_KB(sbi) (1 << ((sbi)->write_io_size_bits + 2)) /* KB */
> > @@ -161,7 +161,7 @@ struct f2fs_checkpoint {
> > */
> > #define F2FS_ORPHANS_PER_BLOCK 1020
> >
> > -#define GET_ORPHAN_BLOCKS(n) ((n + F2FS_ORPHANS_PER_BLOCK - 1) / \
> > +#define GET_ORPHAN_BLOCKS(n) (((n) + F2FS_ORPHANS_PER_BLOCK - 1) / \
> > F2FS_ORPHANS_PER_BLOCK)
> >
> > struct f2fs_orphan_block {
> > @@ -449,7 +449,7 @@ typedef __le32 f2fs_hash_t;
> > #define F2FS_SLOT_LEN 8
> > #define F2FS_SLOT_LEN_BITS 3
> >
> > -#define GET_DENTRY_SLOTS(x) ((x + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
> > +#define GET_DENTRY_SLOTS(x) (((x) + F2FS_SLOT_LEN - 1) >> F2FS_SLOT_LEN_BITS)
> >
> > /* MAX level for dir lookup */
> > #define MAX_DIR_HASH_DEPTH 63
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web