Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1626641 > unrolled thread

Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

Started byFathi Boudra <fathi.boudra@linaro.org>
First post2017-04-19 19:40 +0200
Last post2017-04-19 22:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 Fathi Boudra <fathi.boudra@linaro.org> - 2017-04-19 19:40 +0200
    Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for  aarch64/arm64 Shuah Khan <shuah@kernel.org> - 2017-04-19 22:30 +0200

#1626641 — Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

FromFathi Boudra <fathi.boudra@linaro.org>
Date2017-04-19 19:40 +0200
SubjectRe: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
Message-ID<ty1Ka-6hB-23@gated-at.bofh.it>
gentle ping

On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
> It covers only the native build because it's computed from uname -m output.
> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
> the test.
> Fix the test to allow both native and cross-compilation of the test.
>
> Note: glibc is missing several of the TRAP_* constants in the userspace
>       definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>       See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
>  tools/testing/selftests/breakpoints/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..6b214b7b10fb 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>  ifeq ($(ARCH),x86)
>  TEST_GEN_PROGS := breakpoint_test
>  endif
> -ifeq ($(ARCH),aarch64)
> +ifneq (,$(filter $(ARCH),aarch64 arm64))
>  TEST_GEN_PROGS := breakpoint_test_arm64
>  endif
>
> --
> 2.11.0
>

[toc] | [next] | [standalone]


#1626776 — Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

FromShuah Khan <shuah@kernel.org>
Date2017-04-19 22:30 +0200
SubjectRe: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
Message-ID<ty4oG-7U8-29@gated-at.bofh.it>
In reply to#1626641
On 04/19/2017 11:31 AM, Fathi Boudra wrote:
> gentle ping
> 
> On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
>> It covers only the native build because it's computed from uname -m output.
>> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
>> the test.
>> Fix the test to allow both native and cross-compilation of the test.
>>
>> Note: glibc is missing several of the TRAP_* constants in the userspace
>>       definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>>       See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>

I plan to get to it towards the end of this week. Thanks for
the ping.

-- Shuah

>> ---
>>  tools/testing/selftests/breakpoints/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
>> index 72aa103e4141..6b214b7b10fb 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>>  ifeq ($(ARCH),x86)
>>  TEST_GEN_PROGS := breakpoint_test
>>  endif
>> -ifeq ($(ARCH),aarch64)
>> +ifneq (,$(filter $(ARCH),aarch64 arm64))
>>  TEST_GEN_PROGS := breakpoint_test_arm64
>>  endif
>>
>> --
>> 2.11.0
>>
> 
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web