Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1622395 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2017-04-12 19:30 +0200 |
| Last post | 2017-04-19 21:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-12 19:30 +0200
Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:00 +0200
Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas <javier@osg.samsung.com> - 2017-04-19 21:20 +0200
Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Wolfram Sang <wsa@the-dreams.de> - 2017-04-19 21:50 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-04-12 19:30 +0200 |
| Subject | [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example |
| Message-ID | <tvufD-7kr-9@gated-at.bofh.it> |
The example contains a device node for a retu device, but
its compatible string doesn't have a vendor prefix.
While being there, drop the -mfd suffix since isn't correct.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Tony Lindgren <tony@atomide.com>
---
Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
Changes in v4:
- Avoid using MFD in Device Tree (Lee Jones).
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
index 8ce9cd2855b5..c143948b2a37 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
@@ -20,8 +20,8 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
- retu-mfd: retu@1 {
- compatible = "retu-mfd";
+ retu: retu@1 {
+ compatible = "nokia,retu";
reg = <0x1>;
};
};
--
2.9.3
[toc] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-04-19 21:00 +0200 |
| Subject | Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example |
| Message-ID | <ty2Zz-6X8-9@gated-at.bofh.it> |
| In reply to | #1622395 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
> The example contains a device node for a retu device, but
> its compatible string doesn't have a vendor prefix.
>
> While being there, drop the -mfd suffix since isn't correct.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Acked-by: Tony Lindgren <tony@atomide.com>
Wouldn't it be nice if we fix the driver also so it actually matches the
below compatible? I can't find such a change in linux-next.
> ---
>
> Changes in v5:
> - Add Rob Herring's Acked-by tag.
> - Add Aaro Koskinen's Acked-by tag.
> - Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
>
> Changes in v4:
> - Avoid using MFD in Device Tree (Lee Jones).
>
> Changes in v3: None
> Changes in v2: None
>
> Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> index 8ce9cd2855b5..c143948b2a37 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
> @@ -20,8 +20,8 @@ i2c@0 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - retu-mfd: retu@1 {
> - compatible = "retu-mfd";
> + retu: retu@1 {
> + compatible = "nokia,retu";
> reg = <0x1>;
> };
> };
> --
> 2.9.3
>
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-04-19 21:20 +0200 |
| Subject | Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example |
| Message-ID | <ty3iV-7im-3@gated-at.bofh.it> |
| In reply to | #1626712 |
Hello Wolfram,
On 04/19/2017 02:51 PM, Wolfram Sang wrote:
> On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote:
>> The example contains a device node for a retu device, but
>> its compatible string doesn't have a vendor prefix.
>>
>> While being there, drop the -mfd suffix since isn't correct.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>
> Wouldn't it be nice if we fix the driver also so it actually matches the
> below compatible? I can't find such a change in linux-next.
>
[snip]
>>
>> - retu-mfd: retu@1 {
>> - compatible = "retu-mfd";
>> + retu: retu@1 {
>> + compatible = "nokia,retu";
>> reg = <0x1>;
>> };
You mean having a "nokia,retu" entry in a OF table?
That's done by patch 3/8 in this series:
http://www.spinics.net/lists/devicetree/msg173145.html
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
[toc] | [prev] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2017-04-19 21:50 +0200 |
| Subject | Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example |
| Message-ID | <ty3LY-7rV-19@gated-at.bofh.it> |
| In reply to | #1622395 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote: > The example contains a device node for a retu device, but > its compatible string doesn't have a vendor prefix. > > While being there, drop the -mfd suffix since isn't correct. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Rob Herring <robh@kernel.org> > Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi> > Acked-by: Tony Lindgren <tony@atomide.com> > Reviewed-by: Wolfram Sang <wsa@the-dreams.de> I assume this goes with the rest of the series and not via my tree.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web