Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1626642 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-04-19 19:50 +0200 |
| Last post | 2017-04-19 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-04-19 19:50 +0200
Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-19 20:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-04-19 19:50 +0200 |
| Subject | [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused |
| Message-ID | <ty1TP-6kT-5@gated-at.bofh.it> |
We get a harmless warning without CONFIG_PM:
drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]
Marking the function as __maybe_unused does the right thing here
and drops it silently when unused.
Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/memory/atmel-ebi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 35910f945bfa..99e644cda4d1 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
return of_platform_populate(np, NULL, NULL, dev);
}
-static int atmel_ebi_resume(struct device *dev)
+static __maybe_unused int atmel_ebi_resume(struct device *dev)
{
struct atmel_ebi *ebi = dev_get_drvdata(dev);
struct atmel_ebi_dev *ebid;
--
2.9.0
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-04-19 20:00 +0200 |
| Message-ID | <ty23w-6o6-29@gated-at.bofh.it> |
| In reply to | #1626642 |
On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote:
> We get a harmless warning without CONFIG_PM:
>
> drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]
>
> Marking the function as __maybe_unused does the right thing here
> and drops it silently when unused.
>
> Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sure,
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I think you can safely take it through arm-soc directly.
> ---
> drivers/memory/atmel-ebi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 35910f945bfa..99e644cda4d1 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
> return of_platform_populate(np, NULL, NULL, dev);
> }
>
> -static int atmel_ebi_resume(struct device *dev)
> +static __maybe_unused int atmel_ebi_resume(struct device *dev)
> {
> struct atmel_ebi *ebi = dev_get_drvdata(dev);
> struct atmel_ebi_dev *ebid;
> --
> 2.9.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web