Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624868 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-04-17 22:40 +0200 |
| Last post | 2017-04-18 10:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] um: Include kbuild.h instead of duplicating its macros Matthias Kaehlcke <mka@chromium.org> - 2017-04-17 22:40 +0200
Re: [PATCH] um: Include kbuild.h instead of duplicating its macros Richard Weinberger <richard@nod.at> - 2017-04-18 09:50 +0200
Re: [PATCH] um: Include kbuild.h instead of duplicating its macros Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-18 10:20 +0200
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-04-17 22:40 +0200 |
| Subject | Re: [PATCH] um: Include kbuild.h instead of duplicating its macros |
| Message-ID | <txlBf-5gA-13@gated-at.bofh.it> |
El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
> #include <linux/sched.h>
> #include <linux/elf.h>
> #include <linux/crypto.h>
> +#include <linux/kbuild.h>
> #include <asm/mman.h>
>
> -#define DEFINE(sym, val) \
> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> - DEFINE(sym, offsetof(struct str, mem));
> -
> void foo(void)
> {
> #include <common-offsets.h>
> --
Ping, any comment on this patch?
Cheers
Matthias
[toc] | [next] | [standalone]
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Date | 2017-04-18 09:50 +0200 |
| Message-ID | <txw3E-3rt-7@gated-at.bofh.it> |
| In reply to | #1624868 |
Matthias,
Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>> @@ -2,16 +2,9 @@
>> #include <linux/sched.h>
>> #include <linux/elf.h>
>> #include <linux/crypto.h>
>> +#include <linux/kbuild.h>
>> #include <asm/mman.h>
>>
>> -#define DEFINE(sym, val) \
>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>> -
>> -#define BLANK() asm volatile("\n->" : : )
>> -
>> -#define OFFSET(sym, str, mem) \
>> - DEFINE(sym, offsetof(struct str, mem));
>> -
>> void foo(void)
>> {
>> #include <common-offsets.h>
>> --
>
> Ping, any comment on this patch?
Looks good, nothing exploded while a quick test.
I'll queue it for the next merge window. :-)
Thanks,
//richard
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2017-04-18 10:20 +0200 |
| Message-ID | <txwwH-3Q5-27@gated-at.bofh.it> |
| In reply to | #1625105 |
2017-04-18 16:44 GMT+09:00 Richard Weinberger <richard@nod.at>:
> Matthias,
>
> Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
>> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
>>
>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>>
>>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> @@ -2,16 +2,9 @@
>>> #include <linux/sched.h>
>>> #include <linux/elf.h>
>>> #include <linux/crypto.h>
>>> +#include <linux/kbuild.h>
>>> #include <asm/mman.h>
>>>
>>> -#define DEFINE(sym, val) \
>>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>>> -
>>> -#define BLANK() asm volatile("\n->" : : )
>>> -
>>> -#define OFFSET(sym, str, mem) \
>>> - DEFINE(sym, offsetof(struct str, mem));
>>> -
>>> void foo(void)
>>> {
>>> #include <common-offsets.h>
>>> --
>>
>> Ping, any comment on this patch?
>
> Looks good, nothing exploded while a quick test.
> I'll queue it for the next merge window. :-)
>
> Thanks,
> //richard
If not too late, please feel free to add my
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web