Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625101 > unrolled thread
| Started by | Borislav Petkov <bp@alien8.de> |
|---|---|
| First post | 2017-04-18 09:40 +0200 |
| Last post | 2017-04-18 15:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [lkp-robot] [x86/mce] 5de97c9f6d: WARNING:at_arch/x86/kernel/cpu/mcheck/mce.c:#mce_register_decode_chain Borislav Petkov <bp@alien8.de> - 2017-04-18 09:40 +0200
[tip:ras/core] x86/mce: Update notifier priority check tip-bot for Borislav Petkov <tipbot@zytor.com> - 2017-04-18 15:00 +0200
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-04-18 09:40 +0200 |
| Subject | Re: [lkp-robot] [x86/mce] 5de97c9f6d: WARNING:at_arch/x86/kernel/cpu/mcheck/mce.c:#mce_register_decode_chain |
| Message-ID | <txvTX-3om-1@gated-at.bofh.it> |
On Tue, Apr 18, 2017 at 10:24:45AM +0800, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> commit: 5de97c9f6d85fd83af76e09e338b18e7adb1ae60 ("x86/mce: Factor out and deprecate the /dev/mcelog driver")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>
> in testcase: boot
>
> on test machine: qemu-system-i386 -enable-kvm -m 320M
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
> +------------------------------------------------------------------------+------------+------------+
> | | 011d826111 | 5de97c9f6d |
> +------------------------------------------------------------------------+------------+------------+
> | boot_successes | 4 | 0 |
> | boot_failures | 50 | 12 |
> | WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 50 | 6 |
> | WARNING:at_arch/x86/kernel/cpu/mcheck/mce.c:#mce_register_decode_chain | 0 | 12 |
> +------------------------------------------------------------------------+------------+------------+
>
>
>
> [ 39.479771] WARNING: CPU: 0 PID: 1 at arch/x86/kernel/cpu/mcheck/mce.c:162 mce_register_decode_chain+0x26/0x35
> [ 39.479771] WARNING: CPU: 0 PID: 1 at arch/x86/kernel/cpu/mcheck/mce.c:162 mce_register_decode_chain+0x26/0x35
Ah, that's the prio check. Thanks for reporting, here's a correction:
---
From: Borislav Petkov <bp@suse.de>
Date: Tue, 18 Apr 2017 09:33:28 +0200
Subject: [PATCH] x86/mce: Update notifier priority check
Update the check which enforces the registration of MCE decoder notifier
callbacks with valid priority only, to include mcelog's priority.
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: http://lkml.kernel.org/r/20170418022445.GE1143@yexl-desktop
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index a09bb6775c23..9d41ec8c8927 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -157,7 +157,7 @@ static atomic_t num_notifiers;
void mce_register_decode_chain(struct notifier_block *nb)
{
- if (WARN_ON(nb->priority > MCE_PRIO_LOWEST && nb->priority < MCE_PRIO_EDAC))
+ if (WARN_ON(nb->priority > MCE_PRIO_MCELOG && nb->priority < MCE_PRIO_EDAC))
return;
atomic_inc(&num_notifiers);
--
2.11.0
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [next] | [standalone]
| From | tip-bot for Borislav Petkov <tipbot@zytor.com> |
|---|---|
| Date | 2017-04-18 15:00 +0200 |
| Subject | [tip:ras/core] x86/mce: Update notifier priority check |
| Message-ID | <txATE-6he-19@gated-at.bofh.it> |
| In reply to | #1625101 |
Commit-ID: 415601b1917be0e3b53306d410be659b429241a9
Gitweb: http://git.kernel.org/tip/415601b1917be0e3b53306d410be659b429241a9
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Tue, 18 Apr 2017 09:33:28 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 18 Apr 2017 10:27:52 +0200
x86/mce: Update notifier priority check
Update the check which enforces the registration of MCE decoder notifier
callbacks with valid priority only, to include mcelog's priority.
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: lkp@01.org
Link: http://lkml.kernel.org/r/20170418073820.i6kl5tggcntwlisa@pd.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index a09bb67..9d41ec8 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -157,7 +157,7 @@ static atomic_t num_notifiers;
void mce_register_decode_chain(struct notifier_block *nb)
{
- if (WARN_ON(nb->priority > MCE_PRIO_LOWEST && nb->priority < MCE_PRIO_EDAC))
+ if (WARN_ON(nb->priority > MCE_PRIO_MCELOG && nb->priority < MCE_PRIO_EDAC))
return;
atomic_inc(&num_notifiers);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web