Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621567 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-04-11 21:20 +0200 |
| Last post | 2017-04-17 19:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Matthias Kaehlcke <mka@chromium.org> - 2017-04-11 21:20 +0200
Re: [PATCH] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Dmitry Torokhov <dtor@chromium.org> - 2017-04-15 06:10 +0200
Re: [PATCH] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Matthias Kaehlcke <mka@chromium.org> - 2017-04-17 19:00 +0200
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-04-11 21:20 +0200 |
| Subject | [PATCH] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK |
| Message-ID | <tv9ux-2HL-1@gated-at.bofh.it> |
Besides reusing existing code this removes the special case handling
for 64-bit masks, which causes clang to raise a shift count overflow
warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
Suggested-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
include/linux/clocksource.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index cfc75848a35d..06e604b9e9dc 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -120,7 +120,7 @@ struct clocksource {
#define CLOCK_SOURCE_RESELECT 0x100
/* simplify initialization of mask field */
-#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
+#define CLOCKSOURCE_MASK(bits) (u64)GENMASK_ULL((bits) - 1, 0)
static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
{
--
2.12.2.715.g7642488e1d-goog
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dtor@chromium.org> |
|---|---|
| Date | 2017-04-15 06:10 +0200 |
| Message-ID | <twnc5-1VT-3@gated-at.bofh.it> |
| In reply to | #1621567 |
Hi Matthias,
On Tue, Apr 11, 2017 at 12:17 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> Besides reusing existing code this removes the special case handling
> for 64-bit masks, which causes clang to raise a shift count overflow
> warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
>
> Suggested-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> include/linux/clocksource.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
> index cfc75848a35d..06e604b9e9dc 100644
> --- a/include/linux/clocksource.h
> +++ b/include/linux/clocksource.h
> @@ -120,7 +120,7 @@ struct clocksource {
> #define CLOCK_SOURCE_RESELECT 0x100
>
> /* simplify initialization of mask field */
> -#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
> +#define CLOCKSOURCE_MASK(bits) (u64)GENMASK_ULL((bits) - 1, 0)
I do not think cast to u64 is needed for GENMASK_ULL.
>
> static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from)
> {
> --
> 2.12.2.715.g7642488e1d-goog
>
Thanks,
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-04-17 19:00 +0200 |
| Subject | Re: [PATCH] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK |
| Message-ID | <txiam-32H-15@gated-at.bofh.it> |
| In reply to | #1624019 |
Hi Dmitry,
El Fri, Apr 14, 2017 at 09:02:03PM -0700 Dmitry Torokhov ha dit:
> On Tue, Apr 11, 2017 at 12:17 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > Besides reusing existing code this removes the special case handling
> > for 64-bit masks, which causes clang to raise a shift count overflow
> > warning due to https://bugs.llvm.org//show_bug.cgi?id=10030.
> >
> > Suggested-by: Dmitry Torokhov <dtor@chromium.org>
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > include/linux/clocksource.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
> > index cfc75848a35d..06e604b9e9dc 100644
> > --- a/include/linux/clocksource.h
> > +++ b/include/linux/clocksource.h
> > @@ -120,7 +120,7 @@ struct clocksource {
> > #define CLOCK_SOURCE_RESELECT 0x100
> >
> > /* simplify initialization of mask field */
> > -#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
> > +#define CLOCKSOURCE_MASK(bits) (u64)GENMASK_ULL((bits) - 1, 0)
>
> I do not think cast to u64 is needed for GENMASK_ULL.
Indeed, it is not needed, I will update the patch
Thanks!
Matthias
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web