Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621840 > unrolled thread

[PATCH 0/6] perf tool: build and usage hints

Started byDavid Carrillo-Cisneros <davidcc@google.com>
First post2017-04-12 08:50 +0200
Last post2017-04-12 10:30 +0200
Articles 5 on this page of 25 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/6] perf tool: build and usage hints David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 08:50 +0200
    [PATCH 1/6] perf tools: pass PYTHON config to feature detection David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 08:50 +0200
      [tip:perf/core] perf tools: Pass PYTHON config to feature detection tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-04-17 10:50 +0200
    [PATCH 5/6] perf tools: disable JVMTI if no ELF support available David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 08:50 +0200
      Re: [PATCH 5/6] perf tools: disable JVMTI if no ELF support available Jiri Olsa <jolsa@redhat.com> - 2017-04-12 10:20 +0200
        [PATCH 5/6] perf tools: disable JVMTI if no ELF support available David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 19:10 +0200
          Re: [PATCH 5/6] perf tools: disable JVMTI if no ELF support available Jiri Olsa <jolsa@redhat.com> - 2017-04-12 19:40 +0200
            Re: [PATCH 5/6] perf tools: disable JVMTI if no ELF support available Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-13 16:50 +0200
          [tip:perf/core] perf tools: Disable JVMTI if no ELF support  available tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-04-17 10:50 +0200
      Re: [PATCH 5/6] perf tools: disable JVMTI if no ELF support  available Kim Phillips <kim.phillips@arm.com> - 2017-04-13 13:50 +0200
    [PATCH 2/6] tools build: fix feature redefine build flags David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 09:00 +0200
      Re: [PATCH 2/6] tools build: fix feature redefine build flags Jiri Olsa <jolsa@redhat.com> - 2017-04-12 10:00 +0200
        Re: [PATCH 2/6] tools build: fix feature redefine build flags David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 18:40 +0200
          Re: [PATCH 2/6] tools build: fix feature redefine build flags Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-13 17:00 +0200
    [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 09:00 +0200
      Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid  sorting key Jiri Olsa <jolsa@redhat.com> - 2017-04-12 10:20 +0200
        Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid  sorting key David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 18:40 +0200
          Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid  sorting key Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-13 17:00 +0200
    [PATCH 3/6] perf util: hint missing file when tool tips fail to load David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 09:00 +0200
      [tip:perf/core] perf util: Hint missing file when tool tips fail to  load tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-04-17 10:50 +0200
    [PATCH 2/6] tools build: fix feature detection redefinion of build flags David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 09:00 +0200
      [tip:perf/core] tools build: Fix feature detection redefinion of  build flags tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-04-17 10:50 +0200
    [PATCH 6/6] Revert "perf tools: Fix include of linux/mman.h" David Carrillo-Cisneros <davidcc@google.com> - 2017-04-12 09:00 +0200
      [tip:perf/core] Revert "perf tools: Fix include of linux/mman.h" tip-bot for David Carrillo-Cisneros <tipbot@zytor.com> - 2017-04-17 10:50 +0200
    Re: [PATCH 0/6] perf tool: build and usage hints Jiri Olsa <jolsa@redhat.com> - 2017-04-12 10:30 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1621853 — [PATCH 2/6] tools build: fix feature detection redefinion of build flags

FromDavid Carrillo-Cisneros <davidcc@google.com>
Date2017-04-12 09:00 +0200
Subject[PATCH 2/6] tools build: fix feature detection redefinion of build flags
Message-ID<tvkpY-1dW-27@gated-at.bofh.it>
In reply to#1621840
This change is a follow up of https://lkml.org/lkml/2017/2/2/16

The patch above avoided redefining CC, CXX and PKG_CONFIG in feature
detection. The patch was not merged due to a unsolved concern with
the -MD flag.

Later, commit c8c188679ccf ("tools build: Use the same CC for feature
  detection and actual build")
did the change for CC and CXX but not PKG_CONFIG.

This patch makes PKG_CONFIG consistent with CC and CXX and moves
the -MD to CFLAGS, as suggested by Jiri in the thread above.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/build/feature/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 523e587fe05f..e35e4e5ad192 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -53,17 +53,17 @@ FILES=                                          \
 
 FILES := $(addprefix $(OUTPUT),$(FILES))
 
-CC ?= $(CROSS_COMPILE)gcc -MD
-CXX ?= $(CROSS_COMPILE)g++ -MD
-PKG_CONFIG := $(CROSS_COMPILE)pkg-config
+CC ?= $(CROSS_COMPILE)gcc
+CXX ?= $(CROSS_COMPILE)g++
+PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
 LLVM_CONFIG ?= llvm-config
 
 all: $(FILES)
 
-__BUILD = $(CC) $(CFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
+__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
   BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1
 
-__BUILDXX = $(CXX) $(CXXFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
+__BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
   BUILDXX = $(__BUILDXX) > $(@:.bin=.make.output) 2>&1
 
 ###############################
-- 
2.12.2.715.g7642488e1d-goog

[toc] | [prev] | [next] | [standalone]

#1624604 — [tip:perf/core] tools build: Fix feature detection redefinion of build flags

Fromtip-bot for David Carrillo-Cisneros <tipbot@zytor.com>
Date2017-04-17 10:50 +0200
Subject[tip:perf/core] tools build: Fix feature detection redefinion of build flags
Message-ID<txawa-6Xn-7@gated-at.bofh.it>
In reply to#1621853
Commit-ID:  9961aa665b70e47d6c80141c4a2482266010f246
Gitweb:     http://git.kernel.org/tip/9961aa665b70e47d6c80141c4a2482266010f246
Author:     David Carrillo-Cisneros <davidcc@google.com>
AuthorDate: Tue, 11 Apr 2017 23:49:14 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 13 Apr 2017 11:48:48 -0300

tools build: Fix feature detection redefinion of build flags

This change is a follow up of https://lkml.org/lkml/2017/2/2/16

The patch above avoided redefining CC, CXX and PKG_CONFIG in feature
detection. The patch was not merged due to a unsolved concern with the
-MD flag.

Later, commit c8c188679ccf ("tools build: Use the same CC for feature
detection and actual build") did the change for CC and CXX but not
PKG_CONFIG.

This patch makes PKG_CONFIG consistent with CC and CXX and moves the -MD
to CFLAGS, as suggested by Jiri in the thread above.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Paul Turner <pjt@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Simon Que <sque@chromium.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170412064919.92449-3-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/feature/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 523e587..e35e4e5 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -53,17 +53,17 @@ FILES=                                          \
 
 FILES := $(addprefix $(OUTPUT),$(FILES))
 
-CC ?= $(CROSS_COMPILE)gcc -MD
-CXX ?= $(CROSS_COMPILE)g++ -MD
-PKG_CONFIG := $(CROSS_COMPILE)pkg-config
+CC ?= $(CROSS_COMPILE)gcc
+CXX ?= $(CROSS_COMPILE)g++
+PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
 LLVM_CONFIG ?= llvm-config
 
 all: $(FILES)
 
-__BUILD = $(CC) $(CFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
+__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
   BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1
 
-__BUILDXX = $(CXX) $(CXXFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
+__BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
   BUILDXX = $(__BUILDXX) > $(@:.bin=.make.output) 2>&1
 
 ###############################

[toc] | [prev] | [next] | [standalone]

#1621856 — [PATCH 6/6] Revert "perf tools: Fix include of linux/mman.h"

FromDavid Carrillo-Cisneros <davidcc@google.com>
Date2017-04-12 09:00 +0200
Subject[PATCH 6/6] Revert "perf tools: Fix include of linux/mman.h"
Message-ID<tvkpZ-1dW-33@gated-at.bofh.it>
In reply to#1621840
In https://lkml.org/lkml/2017/2/2/16 I reported a build error
that I believed was caused by wrong uapi includes. The synthom
 was fixed by Arnaldo in:

 commit 2f7db5557994 ("perf tools: Fix include of linux/mman.h")

but I was wrong attributing the problem to the uapi include.
The root cause was that I was using ARCH=x86_64, hence
using the wrong uapi include path. This explains why no one else
ran into this build problem.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
 tools/perf/util/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 76b9c6bc8369..1046a1a83f81 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -1,5 +1,5 @@
 #include <linux/types.h>
-#include <linux/mman.h> /* To get things like MAP_HUGETLB even on older libc headers */
+#include <uapi/linux/mman.h> /* To get things like MAP_HUGETLB even on older libc headers */
 #include <api/fs/fs.h>
 #include "event.h"
 #include "debug.h"
-- 
2.12.2.715.g7642488e1d-goog

[toc] | [prev] | [next] | [standalone]

#1624608 — [tip:perf/core] Revert "perf tools: Fix include of linux/mman.h"

Fromtip-bot for David Carrillo-Cisneros <tipbot@zytor.com>
Date2017-04-17 10:50 +0200
Subject[tip:perf/core] Revert "perf tools: Fix include of linux/mman.h"
Message-ID<txawa-6Xn-15@gated-at.bofh.it>
In reply to#1621856
Commit-ID:  16eb81365b70266c17d1141ef9b32c3110b22d17
Gitweb:     http://git.kernel.org/tip/16eb81365b70266c17d1141ef9b32c3110b22d17
Author:     David Carrillo-Cisneros <davidcc@google.com>
AuthorDate: Tue, 11 Apr 2017 23:49:19 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 13 Apr 2017 11:54:46 -0300

Revert "perf tools: Fix include of linux/mman.h"

In https://lkml.org/lkml/2017/2/2/16 I reported a build error that I
believed was caused by wrong uapi includes. The synthom was fixed by
Arnaldo in:

 commit 2f7db5557994 ("perf tools: Fix include of linux/mman.h")

but I was wrong attributing the problem to the uapi include.

The root cause was that I was using ARCH=x86_64, hence using the wrong
uapi include path. This explains why no one else ran into this build
problem.

Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Paul Turner <pjt@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Simon Que <sque@chromium.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170412064919.92449-8-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 8255a26..4d7e65f 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -1,5 +1,5 @@
 #include <linux/types.h>
-#include <linux/mman.h> /* To get things like MAP_HUGETLB even on older libc headers */
+#include <uapi/linux/mman.h> /* To get things like MAP_HUGETLB even on older libc headers */
 #include <api/fs/fs.h>
 #include "event.h"
 #include "debug.h"

[toc] | [prev] | [next] | [standalone]

#1621921

FromJiri Olsa <jolsa@redhat.com>
Date2017-04-12 10:30 +0200
Message-ID<tvlP4-2b9-17@gated-at.bofh.it>
In reply to#1621840
On Tue, Apr 11, 2017 at 11:49:12PM -0700, David Carrillo-Cisneros wrote:
> Minor build fixes and error condition hints.
> 
> David Carrillo-Cisneros (6):
>   perf tools: pass PYTHON config to feature detection
>   tools build: fix feature detection redefinion of build flags
>   perf util: hint missing file when tool tips fail to load
>   perf report: hint .perfconfig error when invalid sorting key
>   perf tools: disable JVMTI if no ELF support available
>   Revert "perf tools: Fix include of linux/mman.h"

apart from patch 4/6 for series:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web