Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1626083 > unrolled thread
| Started by | "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> |
|---|---|
| First post | 2017-04-19 15:00 +0200 |
| Last post | 2017-04-23 14:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 7/7] powerpc: kprobes: remove duplicate saving of msr "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-04-19 15:00 +0200
Re: [PATCH v3 7/7] powerpc: kprobes: remove duplicate saving of msr Masami Hiramatsu <mhiramat@kernel.org> - 2017-04-19 16:50 +0200
Re: [v3,7/7] powerpc: kprobes: remove duplicate saving of msr Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-04-23 14:00 +0200
| From | "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-04-19 15:00 +0200 |
| Subject | [PATCH v3 7/7] powerpc: kprobes: remove duplicate saving of msr |
| Message-ID | <txXnd-3yQ-53@gated-at.bofh.it> |
set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove the redundant save. Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> --- arch/powerpc/kernel/kprobes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index 067e9863bfdf..5c0a1ffcbcf9 100644 --- a/arch/powerpc/kernel/kprobes.c +++ b/arch/powerpc/kernel/kprobes.c @@ -272,7 +272,6 @@ int __kprobes kprobe_handler(struct pt_regs *regs) */ save_previous_kprobe(kcb); set_current_kprobe(p, regs, kcb); - kcb->kprobe_saved_msr = regs->msr; kprobes_inc_nmissed_count(p); prepare_singlestep(p, regs); kcb->kprobe_status = KPROBE_REENTER; -- 2.12.1
[toc] | [next] | [standalone]
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Date | 2017-04-19 16:50 +0200 |
| Message-ID | <txZ5H-4CC-89@gated-at.bofh.it> |
| In reply to | #1626083 |
On Wed, 19 Apr 2017 18:21:06 +0530 "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > Looks good to me. Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org> Thank you, > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > --- > arch/powerpc/kernel/kprobes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c > index 067e9863bfdf..5c0a1ffcbcf9 100644 > --- a/arch/powerpc/kernel/kprobes.c > +++ b/arch/powerpc/kernel/kprobes.c > @@ -272,7 +272,6 @@ int __kprobes kprobe_handler(struct pt_regs *regs) > */ > save_previous_kprobe(kcb); > set_current_kprobe(p, regs, kcb); > - kcb->kprobe_saved_msr = regs->msr; > kprobes_inc_nmissed_count(p); > prepare_singlestep(p, regs); > kcb->kprobe_status = KPROBE_REENTER; > -- > 2.12.1 > -- Masami Hiramatsu <mhiramat@kernel.org>
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <patch-notifications@ellerman.id.au> |
|---|---|
| Date | 2017-04-23 14:00 +0200 |
| Subject | Re: [v3,7/7] powerpc: kprobes: remove duplicate saving of msr |
| Message-ID | <tzolj-7Zf-1@gated-at.bofh.it> |
| In reply to | #1626083 |
On Wed, 2017-04-19 at 12:51:06 UTC, "Naveen N. Rao" wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > > Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/d08f8a28bcc8c2004a7186839148fc cheers
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web