Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626004 > unrolled thread

Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-04-19 12:40 +0200

#1626004 — Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting

Em Mon, 3 Apr 2017 13:27:48 +0200
Peter Rosin <peda@axentia.se> escreveu:

> On 2017-04-03 12:27, Wolfram Sang wrote:
> > On Mon, Apr 03, 2017 at 10:38:29AM +0200, Peter Rosin wrote:  
> >> Hi!
> >>
> >> Many users of the i2c_mux_add_adapter interface log a message
> >> on failure, but the function already logs such a message. One
> >> or two of those users actually add more information than already
> >> provided by the central failure message.
> >>
> >> So, first fix the central error reporting to provide as much
> >> information as any current user, and then remove the surplus
> >> error reporting at the call sites.  
> > 
> > Yes, I like.
> > 
> > Reviewed-by: Wolfram Sang <wsa@the-dreams.de>  
> 
> Thanks!
> 
> BTW, the improved error reporting in patch 1/9 is not needed for
> patches 8/9 and 9/9 to make sense, the existing central error
> message is already good enough. So, iio and media maintainers,
> feel free to just grab those two patches. Or, they can go via
> Wolfram and the i2c tree with the rest of the series. Either way
> is fine with me, just let me know.

Feel free to submit via I2C tree, together with the patch series:

Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

> 
> Cheers,
> peda



Thanks,
Mauro

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web