Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624872 > unrolled thread
| Started by | Stefan Agner <stefan@agner.ch> |
|---|---|
| First post | 2017-04-17 23:00 +0200 |
| Last post | 2017-04-18 22:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] net: cx89x0: move attribute declaration before struct keyword Stefan Agner <stefan@agner.ch> - 2017-04-17 23:00 +0200
Re: [PATCH v2] net: cx89x0: move attribute declaration before struct keyword David Miller <davem@davemloft.net> - 2017-04-18 22:10 +0200
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2017-04-17 23:00 +0200 |
| Subject | [PATCH v2] net: cx89x0: move attribute declaration before struct keyword |
| Message-ID | <txlUB-5oz-3@gated-at.bofh.it> |
The attribute declaration is typically before the definition. Move
the __maybe_unused attribute declaration before the struct keyword.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Changes in v2:
- Move __maybe_unused after the complete type
drivers/net/ethernet/cirrus/cs89x0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
index 3647b28e8de0..47384f7323ac 100644
--- a/drivers/net/ethernet/cirrus/cs89x0.c
+++ b/drivers/net/ethernet/cirrus/cs89x0.c
@@ -1896,7 +1896,7 @@ static int cs89x0_platform_remove(struct platform_device *pdev)
return 0;
}
-static const struct __maybe_unused of_device_id cs89x0_match[] = {
+static const struct of_device_id __maybe_unused cs89x0_match[] = {
{ .compatible = "cirrus,cs8900", },
{ .compatible = "cirrus,cs8920", },
{ },
--
2.12.2
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-04-18 22:10 +0200 |
| Subject | Re: [PATCH v2] net: cx89x0: move attribute declaration before struct keyword |
| Message-ID | <txHBM-22s-11@gated-at.bofh.it> |
| In reply to | #1624872 |
From: Stefan Agner <stefan@agner.ch> Date: Mon, 17 Apr 2017 13:54:34 -0700 > The attribute declaration is typically before the definition. Move > the __maybe_unused attribute declaration before the struct keyword. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > Changes in v2: > - Move __maybe_unused after the complete type Applied to net-next, thank you.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web