Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624687 > unrolled thread

[PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-04-17 17:10 +0200
Last post2017-04-18 20:10 +0200
Articles 6 on this page of 26 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:10 +0200
    [PATCH 02/25] net: mvneta: Improve two size determinations in  mvneta_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 08/25] net: mvpp2: Improve another size determination in  mvpp2_port_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 04/25] net: mvneta: Adjust six checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 06/25] net: mvpp2: Improve two size determinations in  mvpp2_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 07/25] net: mvpp2: Improve another size determination in  mvpp2_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 09/25] net: mvpp2: Improve another size determination in  mvpp2_bm_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:20 +0200
    [PATCH 19/25] net: mvpp2: Rename a jump label in mvpp2_prs_vlan_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 17/25] net: mvpp2: Rename a jump label in mvpp2_txq_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 12/25] net: mvpp2: Improve a size determination in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 18/25] net: mvpp2: Rename a jump label in  mvpp2_prs_double_vlan_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 11/25] net: mvpp2: Improve 27 size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 10/25] net: mvpp2: Improve another size determination in  mvpp2_prs_default_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 13/25] net: mvpp2: Fix a jump label position in mvpp2_rx() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 14/25] net: mvpp2: Rename a jump label in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 15/25] net: mvpp2: Adjust three error messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 16/25] net: mvpp2: Rename a jump label in  mvpp2_tx_frag_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:30 +0200
    [PATCH 22/25] net: pxa168_eth: Adjust four checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    [PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    [PATCH 24/25] skge: Adjust a null pointer check in skge_down() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    [PATCH 20/25] net: mvpp2: Adjust a null pointer check in  mvpp2_egress_enable() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    [PATCH 23/25] skge: Use seq_puts() in skge_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    [PATCH 25/25] sky2: Use seq_puts() in sky2_debug_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-17 17:40 +0200
    Re: [PATCH 00/25] Ethernet-Marvell: Fine-tuning for several  function implementations David Miller <davem@davemloft.net> - 2017-04-18 20:10 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1624716 — [PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-17 17:40 +0200
Subject[PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions
Message-ID<txgUV-2mc-13@gated-at.bofh.it>
In reply to#1624687
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 14:32:14 +0200

Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index 28cb36d9e50a..2404eac51c63 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -1036,8 +1036,7 @@ static int rxq_init(struct net_device *dev)
 	int rx_desc_num = pep->rx_ring_size;
 
 	/* Allocate RX skb rings */
-	pep->rx_skb = kzalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size,
-			     GFP_KERNEL);
+	pep->rx_skb = kcalloc(rx_desc_num, sizeof(*pep->rx_skb), GFP_KERNEL);
 	if (!pep->rx_skb)
 		return -ENOMEM;
 
@@ -1096,8 +1095,7 @@ static int txq_init(struct net_device *dev)
 	int size = 0, i = 0;
 	int tx_desc_num = pep->tx_ring_size;
 
-	pep->tx_skb = kzalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size,
-			     GFP_KERNEL);
+	pep->tx_skb = kcalloc(tx_desc_num, sizeof(*pep->tx_skb), GFP_KERNEL);
 	if (!pep->tx_skb)
 		return -ENOMEM;
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1624718 — [PATCH 24/25] skge: Adjust a null pointer check in skge_down()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-17 17:40 +0200
Subject[PATCH 24/25] skge: Adjust a null pointer check in skge_down()
Message-ID<txgUW-2mc-27@gated-at.bofh.it>
In reply to#1624687
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 16:08:39 +0200

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written "!skge->mem".

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/marvell/skge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 90bfdbcfd910..5d7d94de4e00 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -2657,7 +2657,7 @@ static int skge_down(struct net_device *dev)
 	struct skge_hw *hw = skge->hw;
 	int port = skge->port;
 
-	if (skge->mem == NULL)
+	if (!skge->mem)
 		return 0;
 
 	netif_info(skge, ifdown, skge->netdev, "disabling interface\n");
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1624720 — [PATCH 20/25] net: mvpp2: Adjust a null pointer check in mvpp2_egress_enable()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-17 17:40 +0200
Subject[PATCH 20/25] net: mvpp2: Adjust a null pointer check in mvpp2_egress_enable()
Message-ID<txgUW-2mc-31@gated-at.bofh.it>
In reply to#1624687
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 14:07:52 +0200

The script "checkpatch.pl" pointed information out like the following.

Comparison to NULL could be written "txq->descs".

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/marvell/mvpp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index 3bdd3f1fe34e..9b875d776b29 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4415,7 +4415,7 @@ static void mvpp2_egress_enable(struct mvpp2_port *port)
 	for (queue = 0; queue < txq_number; queue++) {
 		struct mvpp2_tx_queue *txq = port->txqs[queue];
 
-		if (txq->descs != NULL)
+		if (txq->descs)
 			qmap |= (1 << queue);
 	}
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1624722 — [PATCH 23/25] skge: Use seq_puts() in skge_debug_show()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-17 17:40 +0200
Subject[PATCH 23/25] skge: Use seq_puts() in skge_debug_show()
Message-ID<txgUW-2mc-29@gated-at.bofh.it>
In reply to#1624687
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 15:43:08 +0200

A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/marvell/skge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index edb95271a4f2..90bfdbcfd910 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3718,7 +3718,7 @@ static int skge_debug_show(struct seq_file *seq, void *v)
 			   t->csum_offs, t->csum_write, t->csum_start);
 	}
 
-	seq_printf(seq, "\nRx Ring:\n");
+	seq_puts(seq, "\nRx Ring:\n");
 	for (e = skge->rx_ring.to_clean; ; e = e->next) {
 		const struct skge_rx_desc *r = e->desc;
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1624723 — [PATCH 25/25] sky2: Use seq_puts() in sky2_debug_show()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-04-17 17:40 +0200
Subject[PATCH 25/25] sky2: Use seq_puts() in sky2_debug_show()
Message-ID<txgUW-2mc-33@gated-at.bofh.it>
In reply to#1624687
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 16:15:12 +0200

A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 2b2cc3f3ca10..1145cde2274a 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -4544,7 +4544,7 @@ static int sky2_debug_show(struct seq_file *seq, void *v)
 		   sky2_read32(hw, B0_Y2_SP_ICR));
 
 	if (!netif_running(dev)) {
-		seq_printf(seq, "network not running\n");
+		seq_puts(seq, "network not running\n");
 		return 0;
 	}
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1625508 — Re: [PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations

FromDavid Miller <davem@davemloft.net>
Date2017-04-18 20:10 +0200
SubjectRe: [PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations
Message-ID<txFJE-Tk-23@gated-at.bofh.it>
In reply to#1624687
From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 17:03:33 +0200

> Several update suggestions were taken into account
> from static source code analysis.

Series applied.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web