Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1625443 > unrolled thread

[patch V2 01/10] timer: Invoke timer_start_debug() where it makes sense

Started byThomas Gleixner <tglx@linutronix.de>
First post2017-04-18 18:50 +0200
Last post2017-04-18 18:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [patch V2 01/10] timer: Invoke timer_start_debug() where it makes  sense Thomas Gleixner <tglx@linutronix.de> - 2017-04-18 18:50 +0200

#1625443 — [patch V2 01/10] timer: Invoke timer_start_debug() where it makes sense

FromThomas Gleixner <tglx@linutronix.de>
Date2017-04-18 18:50 +0200
Subject[patch V2 01/10] timer: Invoke timer_start_debug() where it makes sense
Message-ID<txEue-8r4-25@gated-at.bofh.it>
The timer start debug function is called before the proper timer base
is set.

As a consequence the trace data contains the stale CPU and flags values.

Call the debug function after setting the new base and flags.

Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/time/timer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -970,8 +970,6 @@ static inline int
 	if (!ret && pending_only)
 		goto out_unlock;
 
-	debug_activate(timer, expires);
-
 	new_base = get_target_base(base, timer->flags);
 
 	if (base != new_base) {
@@ -994,6 +992,8 @@ static inline int
 		}
 	}
 
+	debug_activate(timer, expires);
+
 	/* Try to forward a stale timer base clock */
 	forward_timer_base(base);
 

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web