Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1624033 > unrolled thread

Re: [git pull] vfs fixes

Started byVegard Nossum <vegard.nossum@gmail.com>
First post2017-04-15 08:50 +0200
Last post2017-04-15 19:10 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [git pull] vfs fixes Vegard Nossum <vegard.nossum@gmail.com> - 2017-04-15 08:50 +0200
    Re: [git pull] vfs fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-04-15 19:00 +0200
      Re: [git pull] vfs fixes Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-15 19:10 +0200

#1624033 — Re: [git pull] vfs fixes

FromVegard Nossum <vegard.nossum@gmail.com>
Date2017-04-15 08:50 +0200
SubjectRe: [git pull] vfs fixes
Message-ID<twpGV-3iC-1@gated-at.bofh.it>
On 9 April 2017 at 07:40, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> The following changes since commit a71c9a1c779f2499fb2afc0553e543f18aff6edf:
>
>   Linux 4.11-rc5 (2017-04-02 17:23:54 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
>
> for you to fetch changes up to a8e28440016bfb23bec266c4c66eacca6ea2d48b:
>
>   Merge branch 'work.statx' into for-next (2017-04-03 01:06:59 -0400)
>
> ----------------------------------------------------------------
> Al Viro (2):
>       alpha: fix stack smashing in old_adjtimex(2)
>       Merge branch 'work.statx' into for-next

I'm seeing the same memfd_create/name_to_handle_at/path_lookupat
use-after-free that Dmitry was seeing here:

https://lkml.org/lkml/2017/3/4/118

I haven't tried the patch from that thread yet, but was there any
reason for it not to get merged so far?


Vegard

[toc] | [next] | [standalone]


#1624092

FromLinus Torvalds <torvalds@linux-foundation.org>
Date2017-04-15 19:00 +0200
Message-ID<twzdf-zg-5@gated-at.bofh.it>
In reply to#1624033
On Fri, Apr 14, 2017 at 11:41 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
> I'm seeing the same memfd_create/name_to_handle_at/path_lookupat
> use-after-free that Dmitry was seeing here:

Ok, see if that is gone in current git with commit c0eb027e5aef ("vfs:
don't do RCU lookup of empty pathnames")

              Linus

[toc] | [prev] | [next] | [standalone]


#1624095

FromAl Viro <viro@ZenIV.linux.org.uk>
Date2017-04-15 19:10 +0200
Message-ID<twzmV-S2-7@gated-at.bofh.it>
In reply to#1624092
On Sat, Apr 15, 2017 at 09:51:40AM -0700, Linus Torvalds wrote:
> On Fri, Apr 14, 2017 at 11:41 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> >
> > I'm seeing the same memfd_create/name_to_handle_at/path_lookupat
> > use-after-free that Dmitry was seeing here:
> 
> Ok, see if that is gone in current git with commit c0eb027e5aef ("vfs:
> don't do RCU lookup of empty pathnames")

FWIW, I'm finishing testing of fixes for crap found during the discussion
of that stuff last week (making sure that mntns_install() can't be abused
into setting ->fs->root/->fs->pwd to dentry of NFS referral and its ilk
and doing that in a sane way).

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web