Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624100 > unrolled thread

[patch 15/20] x86/perf: Drop EXPORT of perf_check_microcode

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [patch 15/20] x86/perf: Drop EXPORT of perf_check_microcode Thomas Gleixner <tglx@linutronix.de> - 2017-04-15 19:40 +0200
    Re: [patch 15/20] x86/perf: Drop EXPORT of perf_check_microcode Borislav Petkov <bp@alien8.de> - 2017-04-18 13:30 +0200

#1624100 — [patch 15/20] x86/perf: Drop EXPORT of perf_check_microcode

The only caller is the microcode update, which cannot be modular.

Drop the export.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org
---
 arch/x86/events/core.c |    1 -
 1 file changed, 1 deletion(-)

--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -2224,7 +2224,6 @@ void perf_check_microcode(void)
 	if (x86_pmu.check_microcode)
 		x86_pmu.check_microcode();
 }
-EXPORT_SYMBOL_GPL(perf_check_microcode);
 
 static struct pmu pmu = {
 	.pmu_enable		= x86_pmu_enable,

[toc] | [next] | [standalone]

#1625268

On Sat, Apr 15, 2017 at 07:01:22PM +0200, Thomas Gleixner wrote:
> The only caller is the microcode update, which cannot be modular.
> 
> Drop the export.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> ---
>  arch/x86/events/core.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/arch/x86/events/core.c
> +++ b/arch/x86/events/core.c
> @@ -2224,7 +2224,6 @@ void perf_check_microcode(void)
>  	if (x86_pmu.check_microcode)
>  		x86_pmu.check_microcode();
>  }
> -EXPORT_SYMBOL_GPL(perf_check_microcode);
>  
>  static struct pmu pmu = {
>  	.pmu_enable		= x86_pmu_enable,

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web